From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1B5B44B511 for ; Sun, 7 Jul 2024 19:48:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B1AD768D95D; Sun, 7 Jul 2024 22:48:48 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 72FDE68D79A for ; Sun, 7 Jul 2024 22:48:42 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C7185FF805 for ; Sun, 7 Jul 2024 19:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720381721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Dfei2SZOFhwm07SfXeMW9S6BqBd+C2Bp1f3uYnROq/s=; b=kkDQJRGWfs45/6uM2J4QFTb4+dntu4CH0sdUZ/d2O4dKrX4O7ulfcL8AVNl4o/iIeOk6Pn EbPkD/RdqQ4S/rsvEc/TjCVtrAtgfG9kjVYp6LaOx0V3DbduWz8HG3gg9eJPE/WZsOFk+q 75bkCcAsCBorNLXoDF/Wt8J7No5WMb5bSk+/O7Gq8O56M/BvYZQLScCQ+BI9J+CqGVI6xh EjZum3HSAm6QfYSigmQ/sHesKlETSJaHrVXDE50MG1eU9e5WKxak+6jF+scocSVAFKcYT2 vO59//4/bqM1QYadltm97fB8318VL88v4QKBF/hj6hBKUB10WLn1JIgbD50Kdg== Date: Sun, 7 Jul 2024 21:48:40 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240707194840.GL4991@pb2> References: <20240526235230.2876318-1-michael@niedermayer.cc> <20240526235230.2876318-4-michael@niedermayer.cc> <20240602202755.GA2821752@pb2> MIME-Version: 1.0 In-Reply-To: <20240602202755.GA2821752@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 04/17] avcodec/dxva2: initialize hr in ff_dxva2_common_end_frame() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5579291439617934501==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5579291439617934501== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j5abB2DrWbqmv6QP" Content-Disposition: inline --j5abB2DrWbqmv6QP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 02, 2024 at 10:27:55PM +0200, Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 09:10:33PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: CID1591924 Uninitialized scalar variable > > > Fixes: CID1591938 Uninitialized scalar variable > > >=20 > > > Sponsored-by: Sovereign Tech Fund > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/dxva2.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c > > > index 1a33c8bbac7..22ecd5acafe 100644 > > > --- a/libavcodec/dxva2.c > > > +++ b/libavcodec/dxva2.c > > > @@ -906,7 +906,7 @@ int ff_dxva2_common_end_frame(AVCodecContext *avc= tx, AVFrame *frame, > > > #endif > > > DECODER_BUFFER_DESC *buffer =3D NULL, *buffer_slice = =3D NULL; > > > int result, runs =3D 0; > > > - HRESULT hr; > > > + HRESULT hr =3D -1; > > > unsigned type; > > > FFDXVASharedContext *sctx =3D DXVA_SHARED_CONTEXT(avctx); > > > =20 > >=20 > > It seems to me that this (and other patches in this set) is not a real > > fix of a bug. These functions are called either with a D3D11 pix fmt or > > with AV_PIX_FMT_DXVA2_VLD, so these variables are initialized before > > their use. >=20 > If they are called with another pixel format then its exploitable > maybe that cannot happen currently >=20 > But if or if not. Initializing these variables makes the code simply > more robust and also if it happens a NULL is easier to debug than > uninitialized variables. The assumtions that need to be true for > them to be initialized are not entirely trivial. >=20 > ill drop the patches from what i wanted to apply currently but i still > think they should be applied. > I can change the commit message if you can suggest something else ? ping does anyone object to the patches ? does someone want a different commit message ? if so which ? I will mark these issues as false positives, as they technically are thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. --j5abB2DrWbqmv6QP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZorxFQAKCRBhHseHBAsP qxc8AJ4kj1ZwGMidLQjZHhV7HMiM5OaZcwCfR2PnR0dtv5hq0EHDlcOSruVcYWU= =NO7J -----END PGP SIGNATURE----- --j5abB2DrWbqmv6QP-- --===============5579291439617934501== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5579291439617934501==--