From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 76B234B507 for ; Sun, 7 Jul 2024 18:56:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8220868DBC2; Sun, 7 Jul 2024 21:56:24 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 60F3F68D94E for ; Sun, 7 Jul 2024 21:56:17 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id A2EEC20004 for ; Sun, 7 Jul 2024 18:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720378576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I+wgCF4APn98Y0O3CbLLhjTofEm7/2q30I/HcpZSDdU=; b=Ex+FCRRY32VvJE49UmAzz22Q5q8CUQsgQ/ckCbGHVlecd37RCgVUQP1DARf2wuB+oxgxOJ ge8n7YJdn0rZjyqm4GK4tto6K1VpFKoYyFksfDGKv+8oWv+kXQnmTuHNGMxbKMV3XpP7ee rz3D679LZbZYsC5pAEWR0EXNZ95vRrJ+ucoy2cgnKESfZ6hv8ZMFobEQjyJnHSv82wLg49 nCr1MJ+AlzdS+EMTlne1z0vW66H9D/vOSW3/zDl11fkjrMT5PS1z8DAdPUOYLRpH5BLUiO kpYMguWngeZvmrNmNoJK1MIjltWAp+Q3o157z/6bQy/GiheuQErwawD4JwGBzg== Date: Sun, 7 Jul 2024 20:56:15 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240707185615.GK4991@pb2> References: <20240704143104.1821386-1-ffmpeg@haasn.xyz> <20240704143104.1821386-3-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20240704143104.1821386-3-ffmpeg@haasn.xyz> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 3/8] swscale/options: relax src/dst_h/v_chr_pos value range X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4717146345543765463==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4717146345543765463== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cLlE6j+44ygFdGhU" Content-Disposition: inline --cLlE6j+44ygFdGhU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 04, 2024 at 04:30:59PM +0200, Niklas Haas wrote: > From: Niklas Haas >=20 > When dealing with 4x subsampling ratios (log2 =3D=3D 2), such as can arise > with 4:1:1 or 4:1:0, a value range of 512 is not enough to cover the > range of possible scenarios. >=20 > For example, bottom-sited chroma in 4:1:0 would require an offset of 768 > (three luma rows). Simply double the limit to 1024. I don't see any > place in initFilter() that would experience overflow as a result of this > change, especially since get_local_pos() right-shifts it by the > subsampling ratio again. > --- > libswscale/options.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) maybe limit it to the max value you know is needed instead of simply doubli= ng. it can be bumped up more later if we run in cases needing more either way LGTM thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao Tsu --cLlE6j+44ygFdGhU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZorkzAAKCRBhHseHBAsP q5KUAJ9rE8lRgWlt0GE++oCO+ctX/x0W2gCdEau64ryo8NPKhIU5D6zhUxQY7wc= =oKbC -----END PGP SIGNATURE----- --cLlE6j+44ygFdGhU-- --===============4717146345543765463== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4717146345543765463==--