From: Steven Liu <lq@chinaffmpeg.org> To: ffmpeg-devel@ffmpeg.org Cc: Steven Liu <lq@chinaffmpeg.org> Subject: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine error message when retry with new http session Date: Sun, 7 Jul 2024 16:49:20 +0800 Message-ID: <20240707084920.7880-1-lq@chinaffmpeg.org> (raw) Fix CID: 1609624 The hlsenc should give error message when hlsenc_io_open error, release memory of filename and options, should return warning message when hlsenc_io_close error. Signed-off-by: Steven Liu <lq@chinaffmpeg.org> --- libavformat/hlsenc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 274de00f9a..494875bc3c 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2617,8 +2617,17 @@ static int hls_write_packet(AVFormatContext *s, AVPacket *pkt) " will retry with a new http session.\n"); ff_format_io_close(s, &vs->out); ret = hlsenc_io_open(s, &vs->out, filename, &options); + if (ret < 0) { + av_log(s, hls->ignore_io_errors ? AV_LOG_WARNING : AV_LOG_ERROR, + "Failed to open file '%s'\n", filename); + av_freep(&filename); + av_dict_free(&options); + return hls->ignore_io_errors ? 0 : ret; + } reflush_dynbuf(vs, &range_length); ret = hlsenc_io_close(s, &vs->out, filename); + if (ret < 0) + av_log(s, AV_LOG_WARNING, "Failed retry upload file '%s' with new http session.\n", oc->url); } av_dict_free(&options); av_freep(&vs->temp_buffer); -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2024-07-07 8:58 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240707084920.7880-1-lq@chinaffmpeg.org \ --to=lq@chinaffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git