From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 23BA94B419 for ; Sat, 6 Jul 2024 16:37:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4229D68DBA1; Sat, 6 Jul 2024 19:37:18 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CB4DF68DAD5 for ; Sat, 6 Jul 2024 19:37:11 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id EB44C1C0002 for ; Sat, 6 Jul 2024 16:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720283831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XKAiJ2xTGitnq6KCZ1hRJrLDJId1PuTxNfRH5P5wayw=; b=IToHPq64uDkU13AXY7Sion90hq3alRrXrTRnaDwatXjrUob0O/VTg0eYFNjVc2+0E3KHZ7 Y9QMw/oa47PIVl+EDfR8Aaec2lLa41NjgH7s1wJZNmVxSHfIskCVLeMJmbEDT7HLZ/wvjY vos2jUXKzJJ0oG4xwNj4bWXeg+4F8PnnETKLioQt8KCpG2dvHb2/z7FLQx22RhQtEWtdbS kO5wcj3WgICYO7mSRGfaJD2Ew+KyIkYJyzcw927Xl+UnMSaIby2ldZpZ+W6KsPN3dmmlYB nI34Zx9XHpxdrnaQUwwb8F95/E1P8xTkiuHUMqXBmtiikvEwXrublPPCK0Nqng== Date: Sat, 6 Jul 2024 18:37:10 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240706163710.GF4991@pb2> References: <20240703210506.75963-1-joshua.allmann@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240703210506.75963-1-joshua.allmann@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4315308265716907228==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4315308265716907228== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="11IAkegDWp8TRrA/" Content-Disposition: inline --11IAkegDWp8TRrA/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 03, 2024 at 02:05:06PM -0700, Josh Allmann wrote: > Encoders may emit a buffering period SEI without a corresponding > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. >=20 > During Annex B conversion, this may result in the SPS/PPS being > inserted *after* the buffering period SEI but before the IDR NAL. >=20 > Since the buffering period SEI references the SPS, the SPS/PPS > needs to come first. > --- > libavcodec/bsf/h264_mp4toannexb.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) breaks fate TEST h264-bsf-mp4toannexb --- ./tests/ref/fate/h264-bsf-mp4toannexb 2024-07-01 23:30:40.656213791 +02= 00 +++ tests/data/fate/h264-bsf-mp4toannexb 2024-07-06 12:13:56.491072296 +0200 @@ -1 +1 @@ -5f04c27cc6ee8625fe2405fb0f7da9a3 +ff2551123909f54c382294baa1bb4364 Test h264-bsf-mp4toannexb failed. Look at tests/data/fate/h264-bsf-mp4toann= exb.err for details. make: *** [tests/Makefile:311: fate-h264-bsf-mp4toannexb] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates --11IAkegDWp8TRrA/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZolysgAKCRBhHseHBAsP q3uiAJ94UgUVDqb2xM0DXGDRFh3VyHR9hQCfS3fIiZcn5PKGi85n1SuIsjRj0Uw= =qhYy -----END PGP SIGNATURE----- --11IAkegDWp8TRrA/-- --===============4315308265716907228== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4315308265716907228==--