From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 33DB24B3ED for ; Fri, 5 Jul 2024 20:08:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B40668DBAE; Fri, 5 Jul 2024 23:08:24 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 59AD268DAF1 for ; Fri, 5 Jul 2024 23:08:18 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B226C20002 for ; Fri, 5 Jul 2024 20:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720210097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2a64uBLvhDiFs8fq4VB+5RBQi8aceY3PVGhT10pM2Fw=; b=mMky6axofaEeHGvcf8ZH1AmNX3xSNUm9iPbmfiFtjMo92TnPHLP7Eq2iks1OZI5uGGHmyb 5frKfCaxBdpNJwiHpAzsA3Za9vMi5OfGmTXoa2XnMdz9bPvttvv1jmmFZtyW/yg4MAL4bz GIUwluWg8hFr7w/DA3lT2oIB0YEco/+lZS4az1KqgueCsGvTPL9vfUEPBfg7BJILmJxQ4i 69Rwi1fQG6TdnfTqZsk2AnOafjyfdRbhNfTRNVLlU/O6UV/1SWvIPrpQmo3a9ZrGA1bHzi /9rWWsbikeHTyEPMryTQ6UlFCiUYDt2fU4gRAkSHeOVP1t2dFp/CcGTPQlKRiw== Date: Fri, 5 Jul 2024 22:08:16 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240705200816.GD4991@pb2> References: <20240630231306.3779027-1-michael@niedermayer.cc> <20240630231306.3779027-11-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8065987752911773008==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8065987752911773008== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1BXV+/FYeXhtv2WT" Content-Disposition: inline --1BXV+/FYeXhtv2WT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 03, 2024 at 02:49:57AM +0200, Lynne via ffmpeg-devel wrote: > On 01/07/2024 01:12, Michael Niedermayer wrote: > > Fixes: CID1605475 Logically dead code > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/aac/aacdec_usac.c | 3 --- > > 1 file changed, 3 deletions(-) > >=20 > > diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c > > index 9587348021e..10121dbc34f 100644 > > --- a/libavcodec/aac/aacdec_usac.c > > +++ b/libavcodec/aac/aacdec_usac.c > > @@ -1676,9 +1676,6 @@ int ff_aac_usac_decode_frame(AVCodecContext *avct= x, AACDecContext *ac, > > } else if (sbr_ratio =3D=3D 3) { > > ratio_mult =3D 2; > > ratio_dec =3D 1; > > - } else if (sbr_ratio =3D=3D 4) { > > - ratio_mult =3D 4; > > - ratio_dec =3D 1; > > } else { > > ratio_mult =3D 1; > > ratio_dec =3D 1; >=20 > Its valid, just not supported at the moment. Maybe just error out with > PATCHWELCOME? > Or mark it as a false positive? yeah, marked as false positive thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt. --1BXV+/FYeXhtv2WT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZohSrQAKCRBhHseHBAsP q5kgAJ4mHsQDtoE9CDZzSSPSEmiP4JzcIgCfX+793Yj221RdDuMZF29pwFOAlj8= =MSOq -----END PGP SIGNATURE----- --1BXV+/FYeXhtv2WT-- --===============8065987752911773008== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8065987752911773008==--