Re: [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio
Date: Fri, 5 Jul 2024 22:08:16 +0200
Message-ID: <20240705200816.GD4991@pb2> (raw)
In-Reply-To: <f070b988-9ccf-4fbf-9146-29ef7532d97c@lynne.ee>

[-- Attachment #1.1: Type: text/plain, Size: 1493 bytes --]

On Wed, Jul 03, 2024 at 02:49:57AM +0200, Lynne via ffmpeg-devel wrote:
> On 01/07/2024 01:12, Michael Niedermayer wrote:
> > Fixes: CID1605475 Logically dead code
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >   libavcodec/aac/aacdec_usac.c | 3 ---
> >   1 file changed, 3 deletions(-)
> > 
> > diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
> > index 9587348021e..10121dbc34f 100644
> > --- a/libavcodec/aac/aacdec_usac.c
> > +++ b/libavcodec/aac/aacdec_usac.c
> > @@ -1676,9 +1676,6 @@ int ff_aac_usac_decode_frame(AVCodecContext *avctx, AACDecContext *ac,
> >       } else if (sbr_ratio == 3) {
> >           ratio_mult = 2;
> >           ratio_dec = 1;
> > -    } else if (sbr_ratio == 4) {
> > -        ratio_mult = 4;
> > -        ratio_dec = 1;
> >       } else {
> >           ratio_mult = 1;
> >           ratio_dec = 1;
> 
> Its valid, just not supported at the moment. Maybe just error out with
> PATCHWELCOME?
> Or mark it as a false positive?

yeah, marked as false positive

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".