Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Marth64 <marth64@proxyid.net>
To: ffmpeg-devel@ffmpeg.org
Cc: Marth64 <marth64@proxyid.net>
Subject: [FFmpeg-devel] [PATCH 1/5] avformat/demux: Copy AVCodecContext properties in codec_close()
Date: Fri,  5 Jul 2024 00:25:51 -0500
Message-ID: <20240705052555.402920-2-marth64@proxyid.net> (raw)
In-Reply-To: <20240705052555.402920-1-marth64@proxyid.net>

After avformat_find_stream_info() calls codec_close(), the
properties are not copied in the newly created skeleton context
returned by codec_close(). This breaks display of the properties
when viewing stream information afterward e.g. via av_dump_format().

Copy the old properties over, thus fixing printing of the properties
(such as Closed Captions) in av_dump_format() that broke sometime
after 4.4.2.

Signed-off-by: Marth64 <marth64@proxyid.net>
---
 libavformat/demux.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/demux.c b/libavformat/demux.c
index dc65f9ad91..72d4ae7593 100644
--- a/libavformat/demux.c
+++ b/libavformat/demux.c
@@ -1298,6 +1298,7 @@ static int codec_close(FFStream *sti)
     if (ret < 0)
         goto fail;
 
+    avctx_new->properties   = sti->avctx->properties;
     avctx_new->pkt_timebase = sti->avctx->pkt_timebase;
 
 #if FF_API_TICKS_PER_FRAME
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-07-05  5:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  5:25 [FFmpeg-devel] [PATCH 0/5] Fix probing display of stream codec properties Marth64
2024-07-05  5:25 ` Marth64 [this message]
2024-07-05  5:25 ` [FFmpeg-devel] [PATCH 2/5] avformat/avformat: Add av_stream_get_codec_properties() to expose internal properties Marth64
2024-07-05  6:09   ` Anton Khirnov
2024-07-05  6:14     ` Marth64
2024-07-05  5:25 ` [FFmpeg-devel] [PATCH 3/5] doc/APIchanges: Bump for av_stream_get_codec_properties() Marth64
2024-07-05  6:02   ` Marth64
2024-07-05  6:02   ` [FFmpeg-devel] [PATCH v2] " Marth64
2024-07-05  5:25 ` [FFmpeg-devel] [PATCH 4/5] fftools/ffprobe: Copy codec properties when creating the ffprobe InputStream Marth64
2024-07-05  5:25 ` [FFmpeg-devel] [PATCH 5/5] tests/ref/fate/ts-demux: Update the expectation to expect closed_captions Marth64

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240705052555.402920-2-marth64@proxyid.net \
    --to=marth64@proxyid.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git