* Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
2024-07-04 19:04 ` [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff Anton Khirnov
@ 2024-07-04 20:33 ` Martin Storsjö
2024-07-04 20:45 ` James Almer
2024-07-05 0:00 ` Andreas Rheinhardt
2 siblings, 0 replies; 11+ messages in thread
From: Martin Storsjö @ 2024-07-04 20:33 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: samples-request
On Thu, 4 Jul 2024, Anton Khirnov wrote:
> Filter output is not bitexact.
> ---
> Reference file at https://up.khirnov.net/7r.pcm, please put it in
> filter-reference/atempo.pcm
> ---
> tests/fate/filter-audio.mak | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
> index cf6065b93f..a3f7aaddbf 100644
> --- a/tests/fate/filter-audio.mak
> +++ b/tests/fate/filter-audio.mak
> @@ -414,7 +414,9 @@ fate-filter-hdcd-s32p: REF = 0c5513e83eedaa10ab6fac9ddc173cf5
>
> FATE_AFILTER_SAMPLES-$(call FILTERDEMDECENCMUX, ATEMPO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-atempo
> fate-filter-atempo: tests/data/asynth-44100-1.wav
> -fate-filter-atempo: CMD = framecrc -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0" -ar 44100
> +fate-filter-atempo: CMD = pcm -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0"
> +fate-filter-atempo: CMP = oneoff
> +fate-filter-atempo: REF = $(SAMPLES)/filter-reference/atempo.pcm
>
> FATE_AFILTER-yes += fate-filter-formats
> fate-filter-formats: libavfilter/tests/formats$(EXESUF)
> --
> 2.43.0
LGTM (once the reference file is in place), thanks, this seems to fix the
issue for me (at least in one failing instance).
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
2024-07-04 19:04 ` [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff Anton Khirnov
2024-07-04 20:33 ` Martin Storsjö
@ 2024-07-04 20:45 ` James Almer
2024-07-05 5:38 ` Anton Khirnov
2024-07-05 0:00 ` Andreas Rheinhardt
2 siblings, 1 reply; 11+ messages in thread
From: James Almer @ 2024-07-04 20:45 UTC (permalink / raw)
To: ffmpeg-devel
On 7/4/2024 4:04 PM, Anton Khirnov wrote:
> Filter output is not bitexact.
> ---
> Reference file at https://up.khirnov.net/7r.pcm, please put it in
> filter-reference/atempo.pcm
How did you create it? x86_32 uses x87 floats which are a lot more
precise than sse ones, for example, so it's best to create a ref file
using such a build.
> ---
> tests/fate/filter-audio.mak | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
> index cf6065b93f..a3f7aaddbf 100644
> --- a/tests/fate/filter-audio.mak
> +++ b/tests/fate/filter-audio.mak
> @@ -414,7 +414,9 @@ fate-filter-hdcd-s32p: REF = 0c5513e83eedaa10ab6fac9ddc173cf5
>
> FATE_AFILTER_SAMPLES-$(call FILTERDEMDECENCMUX, ATEMPO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-atempo
> fate-filter-atempo: tests/data/asynth-44100-1.wav
> -fate-filter-atempo: CMD = framecrc -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0" -ar 44100
> +fate-filter-atempo: CMD = pcm -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0"
> +fate-filter-atempo: CMP = oneoff
> +fate-filter-atempo: REF = $(SAMPLES)/filter-reference/atempo.pcm
>
> FATE_AFILTER-yes += fate-filter-formats
> fate-filter-formats: libavfilter/tests/formats$(EXESUF)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
2024-07-04 20:45 ` James Almer
@ 2024-07-05 5:38 ` Anton Khirnov
2024-07-05 16:04 ` James Almer
0 siblings, 1 reply; 11+ messages in thread
From: Anton Khirnov @ 2024-07-05 5:38 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Quoting James Almer (2024-07-04 22:45:28)
> On 7/4/2024 4:04 PM, Anton Khirnov wrote:
> > Filter output is not bitexact.
> > ---
> > Reference file at https://up.khirnov.net/7r.pcm, please put it in
> > filter-reference/atempo.pcm
>
> How did you create it? x86_32 uses x87 floats which are a lot more
> precise than sse ones, for example, so it's best to create a ref file
> using such a build.
Does it matter when the result is s16 anyway?
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
2024-07-05 5:38 ` Anton Khirnov
@ 2024-07-05 16:04 ` James Almer
2024-07-05 17:18 ` Martin Storsjö
0 siblings, 1 reply; 11+ messages in thread
From: James Almer @ 2024-07-05 16:04 UTC (permalink / raw)
To: ffmpeg-devel
On 7/5/2024 2:38 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-07-04 22:45:28)
>> On 7/4/2024 4:04 PM, Anton Khirnov wrote:
>>> Filter output is not bitexact.
>>> ---
>>> Reference file at https://up.khirnov.net/7r.pcm, please put it in
>>> filter-reference/atempo.pcm
>>
>> How did you create it? x86_32 uses x87 floats which are a lot more
>> precise than sse ones, for example, so it's best to create a ref file
>> using such a build.
>
> Does it matter when the result is s16 anyway?
Eh, who knows. Just in case i generated it on x86_32 with -cpuflags 0,
and uploaded it. Confirm it's fine on your end too, otherwise I'll
replace it with your file.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
2024-07-05 16:04 ` James Almer
@ 2024-07-05 17:18 ` Martin Storsjö
2024-07-05 17:37 ` James Almer
0 siblings, 1 reply; 11+ messages in thread
From: Martin Storsjö @ 2024-07-05 17:18 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Fri, 5 Jul 2024, James Almer wrote:
> On 7/5/2024 2:38 AM, Anton Khirnov wrote:
>> Quoting James Almer (2024-07-04 22:45:28)
>>> On 7/4/2024 4:04 PM, Anton Khirnov wrote:
>>>> Filter output is not bitexact.
>>>> ---
>>>> Reference file at https://up.khirnov.net/7r.pcm, please put it in
>>>> filter-reference/atempo.pcm
>>>
>>> How did you create it? x86_32 uses x87 floats which are a lot more
>>> precise than sse ones, for example, so it's best to create a ref file
>>> using such a build.
>>
>> Does it matter when the result is s16 anyway?
>
> Eh, who knows. Just in case i generated it on x86_32 with -cpuflags 0, and
> uploaded it. Confirm it's fine on your end too, otherwise I'll replace it
> with your file.
The sample you uploaded seems to work fine for me, on aarch64 with clang,
where the test was failing before.
FWIW, re x86_32 and x87 - some compilers default to SSE2 math even for
x86_32 targets these days, so depending on how you build, you may still
get similar behaviour as to x86_64.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
2024-07-05 17:18 ` Martin Storsjö
@ 2024-07-05 17:37 ` James Almer
0 siblings, 0 replies; 11+ messages in thread
From: James Almer @ 2024-07-05 17:37 UTC (permalink / raw)
To: ffmpeg-devel
On 7/5/2024 2:18 PM, Martin Storsjö wrote:
> On Fri, 5 Jul 2024, James Almer wrote:
>
>> On 7/5/2024 2:38 AM, Anton Khirnov wrote:
>>> Quoting James Almer (2024-07-04 22:45:28)
>>>> On 7/4/2024 4:04 PM, Anton Khirnov wrote:
>>>>> Filter output is not bitexact.
>>>>> ---
>>>>> Reference file at https://up.khirnov.net/7r.pcm, please put it in
>>>>> filter-reference/atempo.pcm
>>>>
>>>> How did you create it? x86_32 uses x87 floats which are a lot more
>>>> precise than sse ones, for example, so it's best to create a ref file
>>>> using such a build.
>>>
>>> Does it matter when the result is s16 anyway?
>>
>> Eh, who knows. Just in case i generated it on x86_32 with -cpuflags 0,
>> and uploaded it. Confirm it's fine on your end too, otherwise I'll
>> replace it with your file.
>
> The sample you uploaded seems to work fine for me, on aarch64 with
> clang, where the test was failing before.
>
> FWIW, re x86_32 and x87 - some compilers default to SSE2 math even for
> x86_32 targets these days, so depending on how you build, you may still
> get similar behaviour as to x86_64.
I used gcc 14 and -march=i686 at configure time, so it should not have
sse enabled.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
2024-07-04 19:04 ` [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff Anton Khirnov
2024-07-04 20:33 ` Martin Storsjö
2024-07-04 20:45 ` James Almer
@ 2024-07-05 0:00 ` Andreas Rheinhardt
2024-07-05 5:40 ` Anton Khirnov
2 siblings, 1 reply; 11+ messages in thread
From: Andreas Rheinhardt @ 2024-07-05 0:00 UTC (permalink / raw)
To: ffmpeg-devel
Anton Khirnov:
> Filter output is not bitexact.
> ---
> Reference file at https://up.khirnov.net/7r.pcm, please put it in
> filter-reference/atempo.pcm
Why is the test not shortened to avoid such a huge file?
> ---
> tests/fate/filter-audio.mak | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
> index cf6065b93f..a3f7aaddbf 100644
> --- a/tests/fate/filter-audio.mak
> +++ b/tests/fate/filter-audio.mak
> @@ -414,7 +414,9 @@ fate-filter-hdcd-s32p: REF = 0c5513e83eedaa10ab6fac9ddc173cf5
>
> FATE_AFILTER_SAMPLES-$(call FILTERDEMDECENCMUX, ATEMPO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-atempo
> fate-filter-atempo: tests/data/asynth-44100-1.wav
> -fate-filter-atempo: CMD = framecrc -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0" -ar 44100
> +fate-filter-atempo: CMD = pcm -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0"
> +fate-filter-atempo: CMP = oneoff
> +fate-filter-atempo: REF = $(SAMPLES)/filter-reference/atempo.pcm
>
> FATE_AFILTER-yes += fate-filter-formats
> fate-filter-formats: libavfilter/tests/formats$(EXESUF)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 11+ messages in thread