Re: [FFmpeg-devel] [PATCH 4/5] avformat/mxfenc: Remove dead code

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1329 bytes --]

On Tue, Jun 18, 2024 at 04:32:18PM +0200, Tomas Härdin wrote:
> fre 2024-06-07 klockan 02:32 +0200 skrev Michael Niedermayer:
> > Fixes: CID1524681 Logically dead code
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavformat/mxfenc.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > index f424858fc4e..b8e7bfe3018 100644
> > --- a/libavformat/mxfenc.c
> > +++ b/libavformat/mxfenc.c
> > @@ -2606,9 +2606,6 @@ static int mxf_parse_ffv1_frame(AVFormatContext
> > *s, AVStream *st, AVPacket *pkt)
> >          ff_build_rac_states(&c, 0.05 * (1LL << 32), 256 - 8);
> >          v = get_ffv1_unsigned_symbol(&c, state);
> >          av_assert0(v >= 2);
> > -        if (v > 4) {
> > -            return 0;
> > -        }
> >          if (v > 4) {
> >              av_log(s, AV_LOG_ERROR, "unsupported ffv1 version %d\n",
> > v);
> >              return 0;
> 
> Commit message isn't quite accurate - this rather resurrects the error
> print

right
will apply with a better commit message

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".