* [FFmpeg-devel] [PATCH v2] doc/examples/vaapi_encode: Try to check fwrite() for failure
@ 2024-07-01 23:47 Michael Niedermayer
2024-07-09 6:14 ` Xiang, Haihao
0 siblings, 1 reply; 3+ messages in thread
From: Michael Niedermayer @ 2024-07-01 23:47 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Fixes: CID1604548 Unused value
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
doc/examples/vaapi_encode.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c
index d5f472f6dd8..ff3ebb1e2b8 100644
--- a/doc/examples/vaapi_encode.c
+++ b/doc/examples/vaapi_encode.c
@@ -88,6 +88,10 @@ static int encode_write(AVCodecContext *avctx, AVFrame *frame, FILE *fout)
enc_pkt->stream_index = 0;
ret = fwrite(enc_pkt->data, enc_pkt->size, 1, fout);
av_packet_unref(enc_pkt);
+ if (ret != enc_pkt->size) {
+ ret = AVERROR(errno);
+ break;
+ }
}
end:
--
2.45.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] doc/examples/vaapi_encode: Try to check fwrite() for failure
2024-07-01 23:47 [FFmpeg-devel] [PATCH v2] doc/examples/vaapi_encode: Try to check fwrite() for failure Michael Niedermayer
@ 2024-07-09 6:14 ` Xiang, Haihao
2024-07-09 12:40 ` Michael Niedermayer
0 siblings, 1 reply; 3+ messages in thread
From: Xiang, Haihao @ 2024-07-09 6:14 UTC (permalink / raw)
To: ffmpeg-devel
On Di, 2024-07-02 at 01:47 +0200, Michael Niedermayer wrote:
> Fixes: CID1604548 Unused value
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> doc/examples/vaapi_encode.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c
> index d5f472f6dd8..ff3ebb1e2b8 100644
> --- a/doc/examples/vaapi_encode.c
> +++ b/doc/examples/vaapi_encode.c
> @@ -88,6 +88,10 @@ static int encode_write(AVCodecContext *avctx, AVFrame
> *frame, FILE *fout)
> enc_pkt->stream_index = 0;
> ret = fwrite(enc_pkt->data, enc_pkt->size, 1, fout);
> av_packet_unref(enc_pkt);
> + if (ret != enc_pkt->size) {
> + ret = AVERROR(errno);
> + break;
> + }
> }
>
> end:
LGTM
- Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] doc/examples/vaapi_encode: Try to check fwrite() for failure
2024-07-09 6:14 ` Xiang, Haihao
@ 2024-07-09 12:40 ` Michael Niedermayer
0 siblings, 0 replies; 3+ messages in thread
From: Michael Niedermayer @ 2024-07-09 12:40 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1172 bytes --]
On Tue, Jul 09, 2024 at 06:14:17AM +0000, Xiang, Haihao wrote:
> On Di, 2024-07-02 at 01:47 +0200, Michael Niedermayer wrote:
> > Fixes: CID1604548 Unused value
> >
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > doc/examples/vaapi_encode.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c
> > index d5f472f6dd8..ff3ebb1e2b8 100644
> > --- a/doc/examples/vaapi_encode.c
> > +++ b/doc/examples/vaapi_encode.c
> > @@ -88,6 +88,10 @@ static int encode_write(AVCodecContext *avctx, AVFrame
> > *frame, FILE *fout)
> > enc_pkt->stream_index = 0;
> > ret = fwrite(enc_pkt->data, enc_pkt->size, 1, fout);
> > av_packet_unref(enc_pkt);
> > + if (ret != enc_pkt->size) {
> > + ret = AVERROR(errno);
> > + break;
> > + }
> > }
> >
> > end:
>
> LGTM
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No great genius has ever existed without some touch of madness. -- Aristotle
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-09 12:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-01 23:47 [FFmpeg-devel] [PATCH v2] doc/examples/vaapi_encode: Try to check fwrite() for failure Michael Niedermayer
2024-07-09 6:14 ` Xiang, Haihao
2024-07-09 12:40 ` Michael Niedermayer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git