From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EAF94460F4 for ; Sun, 30 Jun 2024 23:14:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 92EE368D736; Mon, 1 Jul 2024 02:13:37 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 06B3D68D6C5 for ; Mon, 1 Jul 2024 02:13:16 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5EEC540003 for ; Sun, 30 Jun 2024 23:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1719789196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=toYahLZ9OpdG+PiHHx6UEegh0SBHaBjc4wNyIUkm8N8=; b=PImGaZE6n89P7zA382eIWfE16S/hqHIqI+yriszBjmLmanZDoJV+2u+jPsR/Duk/OGEVLV uH0tIFylVgAXibql9kOawkgx/UTJI/YODqSYstdIfnjcfz7lMceCcEGNBubnjVAPd6hZjN e5eZSxakVY5l+TdUNCl6kwNd3a7d24+CZ5vOTOYhHig5okNoUFs+3wsn4BO6CghwRxOj/z U/6OfPsq2XRj9qbU9kFbx1/kDurzvyMbiT3q62udJustwP3Xo/XROJNQMBiMmZukuzllc9 jbqPrp/Rl1HUSux2Zpj0fT5/bVoMI5cY25mMu5N6i9K021LbK0SsvPvd22kmNQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 1 Jul 2024 01:12:48 +0200 Message-ID: <20240630231306.3779027-9-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240630231306.3779027-1-michael@niedermayer.cc> References: <20240630231306.3779027-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 09/11] avcodec/aac/aacdec_lpd: Remove dead code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: I dont intend to apply this, this patch is just to show there is dead code that needs more work in case it has been forgotten I will mark this as intentional in coverity because obviously its work in progress code (CID1603198 Logically dead code) Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec_lpd.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c index 91a32688895..1faaab852f9 100644 --- a/libavcodec/aac/aacdec_lpd.c +++ b/libavcodec/aac/aacdec_lpd.c @@ -142,7 +142,6 @@ int ff_aac_parse_fac_data(AACUsacElemData *ce, GetBitContext *gb, int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac, AACUsacElemData *ce, GetBitContext *gb) { - int k; const uint8_t *mod; int first_ldp_flag; @@ -159,26 +158,7 @@ int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac, if (first_ldp_flag) ce->ldp.last_lpd_mode = -1; /* last_ldp_mode is a **STATEFUL** value */ - k = 0; - while (k < 0) { - if (!k) { - if (ce->ldp.core_mode_last && ce->ldp.fac_data_present) - ff_aac_parse_fac_data(ce, gb, 0, usac->core_frame_len/8); - } else { - if (!ce->ldp.last_lpd_mode && mod[k] > 0 || - ce->ldp.last_lpd_mode && !mod[k]) - ff_aac_parse_fac_data(ce, gb, 0, usac->core_frame_len/8); - } - if (!mod[k]) { -// parse_acelp_coding(); - ce->ldp.last_lpd_mode = 0; - k++; - } else { -// parse_tcx_coding(); - ce->ldp.last_lpd_mode = mod[k]; - k += (1 << (mod[k] - 1)); - } - } + // parse_lpc_data(first_lpd_flag); -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".