From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 09/11] avcodec/aac/aacdec_lpd: Remove dead code Date: Mon, 1 Jul 2024 01:12:48 +0200 Message-ID: <20240630231306.3779027-9-michael@niedermayer.cc> (raw) In-Reply-To: <20240630231306.3779027-1-michael@niedermayer.cc> I dont intend to apply this, this patch is just to show there is dead code that needs more work in case it has been forgotten I will mark this as intentional in coverity because obviously its work in progress code (CID1603198 Logically dead code) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/aac/aacdec_lpd.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c index 91a32688895..1faaab852f9 100644 --- a/libavcodec/aac/aacdec_lpd.c +++ b/libavcodec/aac/aacdec_lpd.c @@ -142,7 +142,6 @@ int ff_aac_parse_fac_data(AACUsacElemData *ce, GetBitContext *gb, int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac, AACUsacElemData *ce, GetBitContext *gb) { - int k; const uint8_t *mod; int first_ldp_flag; @@ -159,26 +158,7 @@ int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac, if (first_ldp_flag) ce->ldp.last_lpd_mode = -1; /* last_ldp_mode is a **STATEFUL** value */ - k = 0; - while (k < 0) { - if (!k) { - if (ce->ldp.core_mode_last && ce->ldp.fac_data_present) - ff_aac_parse_fac_data(ce, gb, 0, usac->core_frame_len/8); - } else { - if (!ce->ldp.last_lpd_mode && mod[k] > 0 || - ce->ldp.last_lpd_mode && !mod[k]) - ff_aac_parse_fac_data(ce, gb, 0, usac->core_frame_len/8); - } - if (!mod[k]) { -// parse_acelp_coding(); - ce->ldp.last_lpd_mode = 0; - k++; - } else { -// parse_tcx_coding(); - ce->ldp.last_lpd_mode = mod[k]; - k += (1 << (mod[k] - 1)); - } - } + // parse_lpc_data(first_lpd_flag); -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-30 23:14 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-30 23:12 [FFmpeg-devel] [PATCH 01/11] MAINTAINERS: Add Timo Rothenpieler to server admins Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 02/11] avcodec/vvc/dec: Check ff_init_cabac_decoder() for failure Michael Niedermayer 2024-07-01 12:54 ` Nuo Mi 2024-07-01 23:51 ` Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 03/11] avcodec/aac/aacdec: Check if frame is allocated in frame_configure_elements() Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 04/11] tools/target_enc_fuzzer: A64MULTI encoder is very slow, check and adjust threshold Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 05/11] tools/target_enc_fuzzer: A64MULTI5 " Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 06/11] doc/examples/mux: remove nop Michael Niedermayer 2024-07-10 19:51 ` Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 07/11] doc/examples/vaapi_encode: Try to check fwrite() for failure Michael Niedermayer 2024-07-01 7:53 ` Rémi Denis-Courmont 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 08/11] fftools/ffmpeg: Check read() " Michael Niedermayer 2024-07-01 11:09 ` Anton Khirnov 2024-06-30 23:12 ` Michael Niedermayer [this message] 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 10/11] avcodec/aac/aacdec_usac: Avoid doing the same thing twice each iteration Michael Niedermayer 2024-07-21 13:56 ` Michael Niedermayer 2024-08-11 10:44 ` Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio Michael Niedermayer 2024-07-03 0:49 ` Lynne via ffmpeg-devel 2024-07-05 20:08 ` Michael Niedermayer 2024-07-01 11:07 ` [FFmpeg-devel] [PATCH 01/11] MAINTAINERS: Add Timo Rothenpieler to server admins Anton Khirnov 2024-07-01 14:07 ` Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240630231306.3779027-9-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git