From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DE52248AEB for ; Sun, 30 Jun 2024 23:13:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB39268CC21; Mon, 1 Jul 2024 02:13:20 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A1F9768D653 for ; Mon, 1 Jul 2024 02:13:10 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 02254FF802 for ; Sun, 30 Jun 2024 23:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1719789190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QhOQaOZ9Qcz22nnvJDfDhArxUNO+9U9egyo6HeeVDEQ=; b=cEKYR6tpUVycK6UUskPp1DGtHhKaRJ0aID77ifRIAGc/UmAfrRBn0+JQVATwXqOREfwOrI tRDB9bIPNnh97VthZ2Cw/jktinzHel6ykApaAxBaex4xHUojSnuXtSNVP/FYp3Oj2h18VL viynQOOaf8NSxwc/1LnMyG/1bAx5sYG0cUlbIVGF9zj6yJizv+3smLvUY/Xx7OcyiocjX1 L729KesVtAVAqqy9GKQ5edNkM2HmgWGDDGO4MqdJOnXV0/2/HD665kBMe6cs/BhV5mYLuG CuXsS+GlGhtCxEkYhvO0FFL4MoI3X58mOZc+aZKXBceg/rrnc7HG9KPVj55yWg== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 1 Jul 2024 01:12:42 +0200 Message-ID: <20240630231306.3779027-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240630231306.3779027-1-michael@niedermayer.cc> References: <20240630231306.3779027-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 03/11] avcodec/aac/aacdec: Check if frame is allocated in frame_configure_elements() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: I did not investigate exactly why frame is NULL, happy to provide the sample if someone wants to investigate further Fixes: NULL pointer dereference Fixes: 69893/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-4965255361396736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index ea2ba84a80c..6a70c69034c 100644 --- a/libavcodec/aac/aacdec.c +++ b/libavcodec/aac/aacdec.c @@ -186,6 +186,9 @@ static int frame_configure_elements(AVCodecContext *avctx) } } + if (!ac->frame) + return AVERROR_INVALIDDATA; + /* get output buffer */ av_frame_unref(ac->frame); if (!avctx->ch_layout.nb_channels) -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".