From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 10/11] avcodec/aac/aacdec_usac: Avoid doing the same thing twice each iteration Date: Mon, 1 Jul 2024 01:12:49 +0200 Message-ID: <20240630231306.3779027-10-michael@niedermayer.cc> (raw) In-Reply-To: <20240630231306.3779027-1-michael@niedermayer.cc> This requires review by the author of the code, i have just changed this so it looks plausible, this needs to be checked against the spec Fixes: CID1603194 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/aac/aacdec_usac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index 4856c1786b7..9587348021e 100644 --- a/libavcodec/aac/aacdec_usac.c +++ b/libavcodec/aac/aacdec_usac.c @@ -313,12 +313,12 @@ int ff_aac_usac_reset_state(AACDecContext *ac, OutputConfiguration *oc) ff_aac_sbr_config_usac(ac, che, e); for (int j = 0; j < ch; j++) { - SingleChannelElement *sce = &che->ch[ch]; + SingleChannelElement *sce = &che->ch[j]; AACUsacElemData *ue = &sce->ue; memset(ue, 0, sizeof(*ue)); - if (!ch) + if (!j) ue->noise.seed = 0x3039; else che->ch[1].ue.noise.seed = 0x10932; -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-30 23:14 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-30 23:12 [FFmpeg-devel] [PATCH 01/11] MAINTAINERS: Add Timo Rothenpieler to server admins Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 02/11] avcodec/vvc/dec: Check ff_init_cabac_decoder() for failure Michael Niedermayer 2024-07-01 12:54 ` Nuo Mi 2024-07-01 23:51 ` Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 03/11] avcodec/aac/aacdec: Check if frame is allocated in frame_configure_elements() Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 04/11] tools/target_enc_fuzzer: A64MULTI encoder is very slow, check and adjust threshold Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 05/11] tools/target_enc_fuzzer: A64MULTI5 " Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 06/11] doc/examples/mux: remove nop Michael Niedermayer 2024-07-10 19:51 ` Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 07/11] doc/examples/vaapi_encode: Try to check fwrite() for failure Michael Niedermayer 2024-07-01 7:53 ` Rémi Denis-Courmont 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 08/11] fftools/ffmpeg: Check read() " Michael Niedermayer 2024-07-01 11:09 ` Anton Khirnov 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 09/11] avcodec/aac/aacdec_lpd: Remove dead code Michael Niedermayer 2024-06-30 23:12 ` Michael Niedermayer [this message] 2024-07-21 13:56 ` [FFmpeg-devel] [PATCH 10/11] avcodec/aac/aacdec_usac: Avoid doing the same thing twice each iteration Michael Niedermayer 2024-08-11 10:44 ` Michael Niedermayer 2024-06-30 23:12 ` [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio Michael Niedermayer 2024-07-03 0:49 ` Lynne via ffmpeg-devel 2024-07-05 20:08 ` Michael Niedermayer 2024-07-01 11:07 ` [FFmpeg-devel] [PATCH 01/11] MAINTAINERS: Add Timo Rothenpieler to server admins Anton Khirnov 2024-07-01 14:07 ` Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240630231306.3779027-10-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git