From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 92B534B043 for ; Wed, 26 Jun 2024 23:05:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BE7BA68D683; Thu, 27 Jun 2024 02:05:30 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5640E68C5B1 for ; Thu, 27 Jun 2024 02:05:24 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B21B51BF204 for ; Wed, 26 Jun 2024 23:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1719443123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o+H0xEipVeZilTyk3gapk+zlhjQkN63dxHR80H4m1Pg=; b=J0eocffrznpahFTqcfnZqM0hNg3hj6vTbWHn/4MDhlVcQURbVysjuBy8TRjUYFT1DTLEPK XUHXtYrduGbLEQ4wFPQ7u6nw9hBLqzYoD05IP3uDx5Q/xelxP7yG/PLhsb8gfywtcCyLyT iIDQdtKrQimpiQurEcrBWkFL5zLIccYyb6U26GHwWPgP2ipOFgEEO227/JJc/AlKewwmdX dDa1JHU405eWU+9fEXRk9q/64n4iCxcXV/sjumPl/P0JsWdO7TtdfQyZQFxtiCc9eRD6j4 UMLHm8P6FKtpG5VNGH2Pt5ujSWvdHmUjKefb2pc5ZHb1YaBbyqE5Ec6bmzXnOQ== Date: Thu, 27 Jun 2024 01:05:22 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240626230522.GU4991@pb2> References: <20240623230137.1749178-1-michael@niedermayer.cc> <20240623230137.1749178-3-michael@niedermayer.cc> <171930604439.21847.16560242901412368252@lain.khirnov.net> <20240625235230.GP4991@pb2> <171938392304.21847.16196117188798759434@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <171938392304.21847.16196117188798759434@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5119482090198395164==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5119482090198395164== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GXtmylMy6DdaH5oR" Content-Disposition: inline --GXtmylMy6DdaH5oR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 26, 2024 at 08:38:43AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-06-26 01:52:30) > > On Tue, Jun 25, 2024 at 11:00:44AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-06-24 01:01:35) > > > > Fixes: NULL pointer dereference > > > > Fixes: 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC= _fuzzer-6549698459009024 > > >=20 > > > seems wrong > >=20 > > Quite possible, but also your comment seems designed to be unhelpfull > > you leave the reader guessing what issue you saw exactly and why and > > what you think is better. >=20 > My comment is designed to be as helpful as your commit message. If you find my commit message inadequate, you should state that. Simply ommiting information you know in a reply is not efficient in moving a review forward >=20 > "Fixes: NULL pointer dereference" says almost nothing about what > actually goes wrong. It should be impossible to get to that point with > the SPS being unset. Assuming it somehow does happen, the correct fix is > to prevent it from happening, not add random checks to random places. If it still reproduces when i look next time and noone else fixed it before then ill investigate what exactly is going on. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates --GXtmylMy6DdaH5oR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZnyergAKCRBhHseHBAsP q1EbAJ9pHpbd9GY/gYWPoKAfkoDb4hFQPgCeL8qP04Cz3xKAKTbRSS6T7lNluRM= =ddC4 -----END PGP SIGNATURE----- --GXtmylMy6DdaH5oR-- --===============5119482090198395164== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5119482090198395164==--