From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start
Date: Thu, 27 Jun 2024 01:05:22 +0200
Message-ID: <20240626230522.GU4991@pb2> (raw)
In-Reply-To: <171938392304.21847.16196117188798759434@lain.khirnov.net>
[-- Attachment #1.1: Type: text/plain, Size: 1473 bytes --]
On Wed, Jun 26, 2024 at 08:38:43AM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2024-06-26 01:52:30)
> > On Tue, Jun 25, 2024 at 11:00:44AM +0200, Anton Khirnov wrote:
> > > Quoting Michael Niedermayer (2024-06-24 01:01:35)
> > > > Fixes: NULL pointer dereference
> > > > Fixes: 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6549698459009024
> > >
> > > seems wrong
> >
> > Quite possible, but also your comment seems designed to be unhelpfull
> > you leave the reader guessing what issue you saw exactly and why and
> > what you think is better.
>
> My comment is designed to be as helpful as your commit message.
If you find my commit message inadequate, you should state that.
Simply ommiting information you know in a reply is not efficient
in moving a review forward
>
> "Fixes: NULL pointer dereference" says almost nothing about what
> actually goes wrong. It should be impossible to get to that point with
> the SPS being unset. Assuming it somehow does happen, the correct fix is
> to prevent it from happening, not add random checks to random places.
If it still reproduces when i look next time and noone else fixed it
before then ill investigate what exactly is going on.
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-26 23:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 23:01 [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac Michael Niedermayer
2024-06-23 23:01 ` [FFmpeg-devel] [PATCH 2/5] avcodec/hevc/hevcdec: Do not allow changes to parameter sets between slices Michael Niedermayer
2024-06-25 8:59 ` Anton Khirnov
2024-06-25 23:27 ` Michael Niedermayer
2024-06-26 6:36 ` Anton Khirnov
2024-06-23 23:01 ` [FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start Michael Niedermayer
2024-06-25 9:00 ` Anton Khirnov
2024-06-25 23:52 ` Michael Niedermayer
2024-06-26 6:38 ` Anton Khirnov
2024-06-26 23:05 ` Michael Niedermayer [this message]
2024-06-23 23:01 ` [FFmpeg-devel] [PATCH 4/5] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices Michael Niedermayer
2024-06-25 9:04 ` Anton Khirnov
2024-06-23 23:01 ` [FFmpeg-devel] [PATCH 5/5] avformat/iamf: Check substreams in ff_iamf_free_audio_element() Michael Niedermayer
2024-07-15 14:25 ` Michael Niedermayer
2024-07-15 15:16 ` James Almer
2024-06-25 23:35 ` [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac Lynne via ffmpeg-devel
2024-06-25 23:57 ` Michael Niedermayer
2024-06-26 6:58 ` Lynne via ffmpeg-devel
2024-06-26 18:57 ` Michael Niedermayer
2024-06-26 19:45 ` Andreas Rheinhardt
2024-06-26 22:46 ` Lynne via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626230522.GU4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git