From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ED3B14AF9D for ; Tue, 25 Jun 2024 19:47:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF71E68D63E; Tue, 25 Jun 2024 22:47:12 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EF6C468D586 for ; Tue, 25 Jun 2024 22:47:06 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 58B51C0002 for ; Tue, 25 Jun 2024 19:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1719344826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Icb3jNL8RGoNBdRuoXcgSysSHLGMv44F3JebUaeaeVY=; b=M7iH3OSMkfuGj5M5Uttam/JFDGxNajN3msKj/9ZqZk5NyPzeFP3S+HHqev02sKUD3Y6smx CEEAclOpjl37Cm5W1haYiez5MiUFdhkVcYUpZQargtieeQbUkBOCvgUtlz2Lr+8CkTIXG7 e53VR8F2SYyvAzwFdlDv9zv6QVQ7heHOT9ScIY16c1I6HEnYrhDAKYrl7Wfl0ZZk1vhnz7 F6D2NwYSII8dorMiuDvYbxVQmi1aCRORbW0iyx0lvkgAEMhXLgQOvjuTxesx+E6HX0DgHP KEpF5/NDr2WxMSk762B7Q8oxbYcQh6pxMoaU2OGvLFHeM9DsogWxI2ntVfs+Gw== Date: Tue, 25 Jun 2024 21:47:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240625194705.GH4991@pb2> References: <20240426235211.3718252-1-michael@niedermayer.cc> <20240426235211.3718252-3-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/decode: Check progress before dereferencing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0608387561744418258==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0608387561744418258== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="a58rN+WbXIGauCK9" Content-Disposition: inline --a58rN+WbXIGauCK9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 27, 2024 at 01:13:54PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: NULL pointer dereference > > Fixes: 68192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP8_fuzz= er-6180311026171904 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/decode.c | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > > index d031b1ca176..a6131941f43 100644 > > --- a/libavcodec/decode.c > > +++ b/libavcodec/decode.c > > @@ -1744,6 +1744,8 @@ void ff_progress_frame_report(ProgressFrame *f, i= nt n) > > =20 > > void ff_progress_frame_await(const ProgressFrame *f, int n) > > { > > + if (!f->progress) > > + return; > > ff_thread_progress_await(&f->progress->progress, n); > > } > > =20 >=20 > Can I get the sample? I see two places in VP8 where the VP8Frame > pointers are set before the actual frame inside it is properly allocated. >=20 > (Actually, it was intended for this API to not support waiting on > non-existent frames (i.e. let the caller check for this; in most > instances, it is already guaranteed that the frame one waits one exists, > so this is unnecessary for them).) did you receive the sample i sent you in april ? any update on this ? its still crashing without this patch Running: 68192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP8_fuzzer= -6180311026171904 libavcodec/decode.c:1766:44: runtime error: member access within null point= er of type 'struct ProgressInternal' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior libavcodec/decode.c= :1766:44 in libavcodec/threadprogress.c:72:36: runtime error: member access within null= pointer of type 'ThreadProgress' (aka 'struct ThreadProgress') SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior libavcodec/threadpr= ogress.c:72:36 in thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato=20 --a58rN+WbXIGauCK9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZnsetgAKCRBhHseHBAsP q6DUAKCFArtFuJu9Xnvj/Yx3Gjl+iJlfVQCglEeZhZIvZADv+ogwvGGg3T9Su3w= =5h3D -----END PGP SIGNATURE----- --a58rN+WbXIGauCK9-- --===============0608387561744418258== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0608387561744418258==--