From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31A8B4AF83 for ; Tue, 25 Jun 2024 19:25:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 46C8F68D65E; Tue, 25 Jun 2024 22:25:54 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6099E68D636 for ; Tue, 25 Jun 2024 22:25:48 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B88311C0003 for ; Tue, 25 Jun 2024 19:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1719343547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n/wNl3yIUkjM2WokrURrVNqL4Bi20wJZsrlk7XcxcTc=; b=LLcW+E89Wy6NbRU6o6gM2biAQLbv/rob5ZIfysOi0pFmmBFuW0hpKnJx0p636CEIPVh4Ym adPf244Pll8X4rdaw264XI/6I4W3jaJp+a5wvpzK9lcVNgvgQd6rYaRzkygwwnV+lqSz8i 6Dn3olY6cH5RoBdpkxA6CPHiGpNHF85fSyFn8D1lO766yR9o0CO3ak2AhFVC2oF3l+kCXG fBOPHIU4WAQWZvOobrplBr+e3erza2FHYU0rNngb+JClsS3IeNRQ4LnBhzueEA4ngqKXPF FAueVtbmqu7aCPrBTogeDrQFulR+ZTK7Tnto+xpND+X2OtVB/7GAnC7z5vqMeA== Date: Tue, 25 Jun 2024 21:25:46 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240625192546.GG4991@pb2> References: <20240322230818.18997-1-michael@niedermayer.cc> <171152515798.7287.8979021106267679923@lain.khirnov.net> <20240327232702.GM6420@pb2> MIME-Version: 1.0 In-Reply-To: <20240327232702.GM6420@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2627160480286866246==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2627160480286866246== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TALVG7vV++YnpwZG" Content-Disposition: inline --TALVG7vV++YnpwZG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 28, 2024 at 12:27:02AM +0100, Michael Niedermayer wrote: > On Wed, Mar 27, 2024 at 08:39:17AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-03-23 00:08:16) > > > Fixes: Timeout > > > Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-579= 1144363491328 > > >=20 > > > Found-by: continuous fuzzing process https://github.com/google/oss-fu= zz/tree/master/projects/ffmpeg > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavformat/cafdec.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > >=20 > > > diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c > > > index 426c56b9bd..334077efb5 100644 > > > --- a/libavformat/cafdec.c > > > +++ b/libavformat/cafdec.c > > > @@ -33,6 +33,7 @@ > > > #include "isom.h" > > > #include "mov_chan.h" > > > #include "libavcodec/flac.h" > > > +#include "libavcodec/internal.h" > > > #include "libavutil/intreadwrite.h" > > > #include "libavutil/intfloat.h" > > > #include "libavutil/dict.h" > > > @@ -87,6 +88,10 @@ static int read_desc_chunk(AVFormatContext *s) > > > st->codecpar->ch_layout.nb_channels =3D avio_rb32(pb); > > > st->codecpar->bits_per_coded_sample =3D avio_rb32(pb); > > > =20 > > > + if (st->codecpar->ch_layout.nb_channels > FF_SANE_NB_CHANNELS || > >=20 > > I dislike this. >=20 > I dislike it too so what do we do about this ? any objections to apply this ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If the United States is serious about tackling the national security threat= s=20 related to an insecure 5G network, it needs to rethink the extent to which = it values corporate profits and government espionage over security.-Bruce Schn= eier --TALVG7vV++YnpwZG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZnsZugAKCRBhHseHBAsP qyWSAJ9qGPiA0C+VV7mBSgZHIBrU1FK7IACfQWCzExkWlWVfmVmdfh1b6k0h3OQ= =HUMa -----END PGP SIGNATURE----- --TALVG7vV++YnpwZG-- --===============2627160480286866246== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2627160480286866246==--