Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps
Date: Tue, 25 Jun 2024 21:25:46 +0200
Message-ID: <20240625192546.GG4991@pb2> (raw)
In-Reply-To: <20240327232702.GM6420@pb2>

[-- Attachment #1.1: Type: text/plain, Size: 1779 bytes --]

On Thu, Mar 28, 2024 at 12:27:02AM +0100, Michael Niedermayer wrote:
> On Wed, Mar 27, 2024 at 08:39:17AM +0100, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2024-03-23 00:08:16)
> > > Fixes: Timeout
> > > Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5791144363491328
> > > 
> > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > ---
> > >  libavformat/cafdec.c | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
> > > index 426c56b9bd..334077efb5 100644
> > > --- a/libavformat/cafdec.c
> > > +++ b/libavformat/cafdec.c
> > > @@ -33,6 +33,7 @@
> > >  #include "isom.h"
> > >  #include "mov_chan.h"
> > >  #include "libavcodec/flac.h"
> > > +#include "libavcodec/internal.h"
> > >  #include "libavutil/intreadwrite.h"
> > >  #include "libavutil/intfloat.h"
> > >  #include "libavutil/dict.h"
> > > @@ -87,6 +88,10 @@ static int read_desc_chunk(AVFormatContext *s)
> > >      st->codecpar->ch_layout.nb_channels = avio_rb32(pb);
> > >      st->codecpar->bits_per_coded_sample = avio_rb32(pb);
> > >  
> > > +    if (st->codecpar->ch_layout.nb_channels > FF_SANE_NB_CHANNELS ||
> > 
> > I dislike this.
> 
> I dislike it too

so what do we do about this ?
any objections to apply this ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If the United States is serious about tackling the national security threats 
related to an insecure 5G network, it needs to rethink the extent to which it
values corporate profits and government espionage over security.-Bruce Schneier

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".