From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6006D4AF37 for ; Tue, 25 Jun 2024 16:24:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6AEB68D293; Tue, 25 Jun 2024 19:24:54 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7048E68AD62 for ; Tue, 25 Jun 2024 19:24:48 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id A3D85E0004 for ; Tue, 25 Jun 2024 16:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1719332687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lGhQ8IBW3x9gid3fRpvvck4MafdA1Y26pJQCKZ8EHUI=; b=Iagax/DqQ3xU5xvhGLBVg7F7xs2ANL5G8Jep65pnb8DQgD4bMAmVHMenS6x+fz25njSSnN R+2qq9PukSFU33QjEMuuHd/rUEqsYgint1vuqolt29d5yxDYQAjnVDhYxCRQvMyW1l1h2c Zvgo5gtKTTNfwZHIEIaYTeii5E4YhnDPp39SJrSW1hu4TIqqN5SMFIx9iL1UjCOlz/I/jy Ys9aAMplVYaEtckvvWaPGrD5HKmzW9rhll1UkahfWLlQujKpci7y2tg0aaQ08L0mh2oaRT gMjNvgPss27qHWCTDMQcQN2T8v3e0dT8OwC4ut0dUUzw7UaBxPJ08DjycruofA== Date: Tue, 25 Jun 2024 18:24:46 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240625162446.GD4991@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: Don't adapt (last|next)_pic.linesize for field pics X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5183934726571418988==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5183934726571418988== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HjNkcEWJ4DMx36DP" Content-Disposition: inline --HjNkcEWJ4DMx36DP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 24, 2024 at 02:01:42AM +0200, Andreas Rheinhardt wrote: > These values are not read anywhere. Furthermore, since commit > fe6037fd04db8837dcdb9013f9c4ad4e7eb0592e the linesize values > of the MPVWorkPictures were wrong for subsequent fields > in a chain of B-pictures (as they are always doubled and no longer > based upon the frame-linesizes) which can eventually lead to overflow. >=20 > Finally, it makes no real sense to ever double the linesize > of the reference pictures at all: Even when the current picture > is a field, it can still reference both fields of reference > pictures and therefore the linesize should allow to address > both fields (for the same reason, data is not offset for > reference pictures). >=20 > libavcodec/mpeg12dec.c:1304:41: runtime error: signed integer overflow: 4= 611686018427387904 * 2 cannot be represented in type 'long' >=20 > issue: 69732/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEGVIDEO_= fuzzer-5123551179374592 >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg12dec.c | 2 -- > 1 file changed, 2 deletions(-) Tested, fixes the issue thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Some people wanted to paint the bikeshed green, some blue and some pink. People argued and fought, when they finally agreed, only rust was left. --HjNkcEWJ4DMx36DP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZnrvSgAKCRBhHseHBAsP q9oXAJ9XHUof2F3/egKRIU+q/fhOI7J82ACeN1tFXbgLnatsNJC4qSJStgKB1CQ= =cEju -----END PGP SIGNATURE----- --HjNkcEWJ4DMx36DP-- --===============5183934726571418988== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5183934726571418988==--