Re: [FFmpeg-devel] [PATCH 3/3] avutil/stereo3d: set a sane default value for AVRational fields

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1276 bytes --]

On Fri, Jun 21, 2024 at 09:19:36AM -0300, James Almer wrote:
> On 6/18/2024 6:13 PM, Michael Niedermayer wrote:
> > On Tue, Jun 18, 2024 at 04:20:34PM -0300, James Almer wrote:
> > > Prevent potential divisions by 0 when using them immediately after allocation.
> > > 
> > > Signed-off-by: James Almer <jamrial@gmail.com>
> > > ---
> > >   libavutil/stereo3d.c | 14 +++++++++++++-
> > >   1 file changed, 13 insertions(+), 1 deletion(-)
> > 
> > i must have applied the wrong patches locally but this fails to build
> > 
> > CC	libavutil/stereo3d.o
> > libavutil/stereo3d.c: In function ‘get_defaults’:
> > libavutil/stereo3d.c:31:47: error: incompatible types when assigning to type ‘int32_t’ {aka ‘int’} from type ‘AVRational’ {aka ‘struct AVRational’}
> 
> This sounds like you still have Derek's old version in your tree. He has
> since changed it and pushed a different one.

yes, i realized and fixed that after i sent the mail

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".