From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D2750407BC for ; Fri, 21 Jun 2024 19:35:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 49A3168D794; Fri, 21 Jun 2024 22:35:56 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 71DA368D5CA for ; Fri, 21 Jun 2024 22:35:50 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 46C9B240003 for ; Fri, 21 Jun 2024 19:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718998549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lMrYvaLGgDuD+oXSQrZPFsm0Tknb46xLzK5QOuG79P4=; b=g3jq1e/CoXszwU6vfyvqg7wa9nyYgfnYewy0jTr1Rl7q995p+lm/C1aSY/KUtDPsjXmRGd NcpW1iIZ4q442UinD3iyeyiFFmO6pQHn1252UctVw9DPrBBZint1qPCtDAiyruykMpBmBD QGo2+JFlXZbjQTt9JTFQRJLb+b8BkCRIYJcak2oBDlaqLHDwJu1xhz85liY5h1eCAtauua xYmhUSXm3XocLnJ6a17TX8n6gd+2qSLpbHSXybO2x+M1OCXgbfXGukHn3w5T2D74mP1cnT nbYG3vIhMhdkDgsRIdGojNZVc8b0NpdwzcGemnbNA6pxMWUEEL7XgsOAxfVUcA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Fri, 21 Jun 2024 21:35:48 +0200 Message-ID: <20240621193548.2923736-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH] avcodec/osq: avoid signed overflow in downsample path X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes: signed integer overflow: 865309950 * 256 cannot be represented in type 'int' Fixes: 69191/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6310214413385728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/osq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/osq.c b/libavcodec/osq.c index 8a153330269..42a46b25ce5 100644 --- a/libavcodec/osq.c +++ b/libavcodec/osq.c @@ -325,7 +325,7 @@ static int do_decode(AVCodecContext *avctx, AVFrame *frame, int decorrelate, int cb->prev = prev; if (downsample) - dst[n] *= 256; + dst[n] *= 256U; dst[E] = dst[D]; dst[D] = dst[C]; -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".