From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EB8A34B916 for ; Wed, 19 Jun 2024 10:59:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AEC9068D6B6; Wed, 19 Jun 2024 13:59:16 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 459CE68D1A6 for ; Wed, 19 Jun 2024 13:59:10 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 756AC1C0005 for ; Wed, 19 Jun 2024 10:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718794749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gLNBVZ5Z8L1tBklFVeu0IJ8tWDme+/XpMT7uOXtbf14=; b=iAsut9qi+J9k8WoiXHeNCzxgaF7a2TH9yadjUXY6AcM28Gqnd3ZQV1P+FI6qlKLxCoS2EH iJL+jmNcYuilRgZV3Qvpo0Pdc+GP+swlavmRsxwrLQyMrE2QGXL/IoVd5agkGA/8Omzw40 EeztZFPUM3jf6jo7jncEd1/nuWfoVWTV/e6Ouqw0XewV8KB0cN+eXlArp0WqGhfel6wJ3/ L7qMDYZk65SurA8rFAJe7DhEAJ9vktjaLZsqm2dYVcYV28huhR0V4ja/P7prwsaV0w8FGj Omx893NTs0s4jcBWzKySgYAy7Hd2E9mLAhWYokO3aKCPApdWsibWtQH/QJc9Xg== Date: Wed, 19 Jun 2024 12:59:08 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240619105908.GP4991@pb2> References: <20240616230831.912377-1-michael@niedermayer.cc> <20240616230831.912377-6-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3557531863047862712==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3557531863047862712== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iq/fWD14IMVFWBCD" Content-Disposition: inline --iq/fWD14IMVFWBCD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 17, 2024 at 10:10:38AM -0700, James Zern via ffmpeg-devel wrote: > On Sun, Jun 16, 2024 at 4:09=E2=80=AFPM Michael Niedermayer > wrote: > > > > This or fifo needs to be freed on errors explicitly > > I have not verified that its always safe to call vpx_free() this needs = to be checked before applying this > > >=20 > It should be safe to call into libvpx whether the encoder init > succeeded or not; av_freep() is most of the rest of the code. Thanks for checking >=20 > > Fixes: memleak > > Fixes: 68937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_V= P8_fuzzer-4830831016214528 > > > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/libvpxenc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > >=20 > lgtm. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates --iq/fWD14IMVFWBCD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZnK5/AAKCRBhHseHBAsP q1I+AKCEKXMpulmPZiY9pPSVYhjXWxPpQwCfWTEPtH06ANELXefrbhT9g826MaQ= =k7kv -----END PGP SIGNATURE----- --iq/fWD14IMVFWBCD-- --===============3557531863047862712== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3557531863047862712==--