From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2FFD14B911 for ; Wed, 19 Jun 2024 10:54:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0442068D654; Wed, 19 Jun 2024 13:54:22 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5D39468D3E9 for ; Wed, 19 Jun 2024 13:54:15 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B89FF6000C for ; Wed, 19 Jun 2024 10:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718794454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9WcbsWJTCoigk6jeMosCBSqFdgFS4yo2Bh676HJJqZc=; b=CP4L/YTyZmb/IT8k87eQFwKzSgDrerdsFEH7ibYi1ZaaNwnabeR7OfoYwVtaUhwWX6giZU b0IRDAPSkAUYoqqEGzktYCwO2hNvNknbzsPaLeLkKBAj3zLfxlb/YKAi4aCFY6GMBKz694 viO79Cf6ujYaXMoO1IC0wtnx9qLhbtSJNup+M9EvrEw5SoryyThWCDxUXBCghNvckhR/qu 4t1wp/3lhOQZRfivd7zN1Nw+PeGbClHvK4Zs7uClgLGUqhuvEBkCFSqf+a6231HTWD3WuG J5ifJx2SXaKMDfs+Pl6OQ6vUyjXpLMR0encXNwxLeE6PcKfRvu0Qb8Edrx4dAA== Date: Wed, 19 Jun 2024 12:54:13 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240619105413.GN4991@pb2> References: <20240616230831.912377-1-michael@niedermayer.cc> <20240616230831.912377-3-michael@niedermayer.cc> <3f0f5466-d151-47c5-8973-6b191825c70f@gmail.com> MIME-Version: 1.0 In-Reply-To: <3f0f5466-d151-47c5-8973-6b191825c70f@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/9] avformat/iamf_parse: Try to use less space after the array X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5364310828274147604==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5364310828274147604== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cs5saTBZh7UZl2eX" Content-Disposition: inline --cs5saTBZh7UZl2eX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 17, 2024 at 09:35:06PM -0300, James Almer wrote: > On 6/16/2024 8:08 PM, Michael Niedermayer wrote: > > Fixes: out of array access > > Fixes: 68584/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-62566= 56668229632 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/iamf_parse.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c > > index 312090b247c..5c2ff6862a7 100644 > > --- a/libavformat/iamf_parse.c > > +++ b/libavformat/iamf_parse.c > > @@ -355,6 +355,9 @@ static int scalable_channel_layout_config(void *s, = AVIOContext *pb, > > substream_count =3D avio_r8(pb); > > coupled_substream_count =3D avio_r8(pb); > > + if (substream_count + k > audio_element->nb_substreams) > > + return AVERROR_INVALIDDATA; > > + > > audio_element->layers[i].substream_count =3D substrea= m_count; > > audio_element->layers[i].coupled_substream_count =3D coupled_= substream_count; > > if (output_gain_is_present_flag) { >=20 > LGTM, will apply > and ditto, change the commit message. you lack humor ;( thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control. Democracy: All politicians are under surveillance, all their steps and actions recorded, for the citizens to enforce control. --cs5saTBZh7UZl2eX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZnK40gAKCRBhHseHBAsP q519AJ47VP1+MghdQjI+oLskGP5vHoj68ACfZ6v9Rw3BEqru52WbkNIibReH5NQ= =8s9Q -----END PGP SIGNATURE----- --cs5saTBZh7UZl2eX-- --===============5364310828274147604== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5364310828274147604==--