From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3E3C94B8FD for ; Tue, 18 Jun 2024 22:08:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1428268D641; Wed, 19 Jun 2024 01:08:40 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3717868D2A2 for ; Wed, 19 Jun 2024 01:08:34 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 933B240002 for ; Tue, 18 Jun 2024 22:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718748513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jHgrCokbKkNvhhOyb4N4iMbHwKClzL8qVEruZJ+RPZs=; b=lcJeLJhJmUl8NdErBCs8VGPmZ2jiHJ/5hJ4/4aheVRH8oMbeOet647o7eYzIkVmDOnDEwi hgTZr+IVrKK3T6QiLXCOb0d4YpEdU7yXBKXwcWXWdKHkEYqUiyIjjiIfdFtchzD3MTBhz/ izPhg/u2sKRVZN5wQogDh9zI6D86nqqC9Ay5et06MVCZTz+kuAeYkpC/680QisvxooheWb 4PGo04b/jm4kKTRNDnFxVuZLZ2opdyoCMLfi+0H3ClzI5Re1QM8hlXnlqSlDvcSc2hZDcG 1wx+uDUG/buMmH0JMbdA0H8lz+lVpWroLB7clH4ao9QJrVOIS253OB1H3NZHBg== Date: Wed, 19 Jun 2024 00:08:33 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240618220833.GL4991@pb2> References: <20240613072750.GA2821752@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 37/57] avcodec/mpegutils: Don't output wrong mb skip values X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1396914766922411082==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1396914766922411082== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1hKfHPzOXWu1rh0v" Content-Disposition: inline --1hKfHPzOXWu1rh0v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 17, 2024 at 01:08:56PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Jun 12, 2024 at 03:48:33PM +0200, Andreas Rheinhardt wrote: > >> The earlier code had two problems: > >> 1. For reference frames that are not directly output (happens unless > >> low_delay is set), the mb skip values referred to the next reference > >> frame to be decoded. > >> 2. For non-reference frames, every macroblock was always considered > >> skipped. > >> This makes the output (worse than) useless; that no one ever > >> complained about this shows that this feature is not really used. > >> It is therefore removed. > >=20 > > I used it for statistical purposes long ago, seeing how much blocks whe= re > > skiped and for that a +-1 frame difference is inconsequantal. Also > > i understood that B frame are handled differently, its an internal > > bitstream related number after all >=20 > Does "long ago" mean that you agree that it is unused and can be removed? It simply means that it was usefull and a number similar could be usefull again. I dont care much about it, judging from the past i might use this on= ce in 10 years, if its available. If its not available its not. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable --1hKfHPzOXWu1rh0v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZnIFYAAKCRBhHseHBAsP q/iJAJ4rQ686w4YEPQvyFc8uxKsCWeMS0ACfTZhzvOk1E6im3TNoqMzvll5bln0= =B7I5 -----END PGP SIGNATURE----- --1hKfHPzOXWu1rh0v-- --===============1396914766922411082== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1396914766922411082==--