On Mon, Jun 17, 2024 at 01:08:56PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Jun 12, 2024 at 03:48:33PM +0200, Andreas Rheinhardt wrote: > >> The earlier code had two problems: > >> 1. For reference frames that are not directly output (happens unless > >> low_delay is set), the mb skip values referred to the next reference > >> frame to be decoded. > >> 2. For non-reference frames, every macroblock was always considered > >> skipped. > >> This makes the output (worse than) useless; that no one ever > >> complained about this shows that this feature is not really used. > >> It is therefore removed. > > > > I used it for statistical purposes long ago, seeing how much blocks where > > skiped and for that a +-1 frame difference is inconsequantal. Also > > i understood that B frame are handled differently, its an internal > > bitstream related number after all > > Does "long ago" mean that you agree that it is unused and can be removed? It simply means that it was usefull and a number similar could be usefull again. I dont care much about it, judging from the past i might use this once in 10 years, if its available. If its not available its not. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable