From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9A1F44B8EB for ; Tue, 18 Jun 2024 19:23:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EC66468D74A; Tue, 18 Jun 2024 22:23:42 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C6AC68D729 for ; Tue, 18 Jun 2024 22:23:36 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1718738615; bh=BAxVU4yNoMTCa24Cmf8IkeQnD+TWSqbxS3JCUgKW/6c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ba4m4LNO51G6asv5n5DvncujlDmBw/JvaqurAjgY7YhC1rDeLy+/kTG2fPoKHKzQm BogIPX8JEumdE2GSaUx7pJrUc/x2NdRNUXsRNj2LaJtNaqxwIt1CIy4rHU5aFTxMk6 v97S5YrEK8YWVn0GKIUuRSjJKbKBM/kJBuhTa/YE= Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id DCB38403F0; Tue, 18 Jun 2024 21:23:35 +0200 (CEST) Date: Tue, 18 Jun 2024 21:23:35 +0200 Message-ID: <20240618212335.GE9153@haasn.xyz> From: Niklas Haas To: Cosmin Stejerean via ffmpeg-devel , "ffmpeg-devel@ffmpeg.org" In-Reply-To: <0101018fa0ff42c3-64e84889-1be6-4fe9-b882-d6aca669c958-000000@us-west-2.amazonses.com> References: <20240522155031.33491-1-cosmin@cosmin.at> <0101018fa0ff42c3-64e84889-1be6-4fe9-b882-d6aca669c958-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v3 0/2] avcodec/dovi - correctly read el_bit_depth_minus8 and ext_mapping_idc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Cosmin Stejerean Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 22 May 2024 15:50:34 +0000 Cosmin Stejerean via ffmpeg-devel wrote: > From: Cosmin Stejerean > > Some DolbyVision samples fail to parse currently due to mis-reading the > el_bit_depth_minus8 field. Upon investigation it seems that the RPU syntax has > been extended in an as of yet undocumented way by adding ext_mapping_idc and > coding it together with el_bit_depth_minus8 together into a single 16 bit > integer with the upper 8 bits for ext_mapping_idc and the lower 8 bits for > el_bit_depth_minus8. > > This can be observed in the output of the DoVi verifier, which shows how this > is laid out. This patchset adds the new fields to dovi_meta and implements the > code to parse and write this back out. > > Compared to the previous version it moves the fields to the end for ABI > compatibility, bumps the minor version in lavu and splits this into a separate > commit. > > Cosmin Stejerean (2): > lavu/dovi_meta - add fields for ext_mapping_idc > avcodec/dovi - correctly read el_bit_depth_minus8 and ext_mapping_idc > > libavcodec/dovi_rpudec.c | 7 ++++++- > libavcodec/dovi_rpuenc.c | 4 +++- > libavutil/dovi_meta.h | 2 ++ > libavutil/version.h | 2 +- > 4 files changed, 12 insertions(+), 3 deletions(-) > > -- > 2.42.1 > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". As discussed on IRC, this needs an extra patch to update the `last field` entry in `dovi_rpu.c`. Apart from that, LGTM. Will apply tomorrow (with the mentioned change) if there is no objection. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".