Re: [FFmpeg-devel] [PATCH v3 0/2] avcodec/dovi - correctly read el_bit_depth_minus8 and ext_mapping_idc

[Niklas Haas <ffmpeg@haasn.xyz>]

On Wed, 22 May 2024 15:50:34 +0000 Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> From: Cosmin Stejerean <cosmin@cosmin.at>
> 
> Some DolbyVision samples fail to parse currently due to mis-reading the
> el_bit_depth_minus8 field. Upon investigation it seems that the RPU syntax has
> been extended in an as of yet undocumented way by adding ext_mapping_idc and
> coding it together with el_bit_depth_minus8 together into a single 16 bit
> integer with the upper 8 bits for ext_mapping_idc and the lower 8 bits for
> el_bit_depth_minus8.
> 
> This can be observed in the output of the DoVi verifier, which shows how this
> is laid out. This patchset adds the new fields to dovi_meta and implements the
> code to parse and write this back out.
> 
> Compared to the previous version it moves the fields to the end for ABI
> compatibility, bumps the minor version in lavu and splits this into a separate
> commit.
> 
> Cosmin Stejerean (2):
>   lavu/dovi_meta - add fields for ext_mapping_idc
>   avcodec/dovi - correctly read el_bit_depth_minus8 and ext_mapping_idc
> 
>  libavcodec/dovi_rpudec.c | 7 ++++++-
>  libavcodec/dovi_rpuenc.c | 4 +++-
>  libavutil/dovi_meta.h    | 2 ++
>  libavutil/version.h      | 2 +-
>  4 files changed, 12 insertions(+), 3 deletions(-)
> 
> -- 
> 2.42.1
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

As discussed on IRC, this needs an extra patch to update the `last
field` entry in `dovi_rpu.c`.

Apart from that, LGTM. Will apply tomorrow (with the mentioned change)
if there is no objection.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".