From: Niklas Haas <ffmpeg@haasn.xyz>
To: Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>,
"ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: Cosmin Stejerean <cosmin@cosmin.at>
Subject: Re: [FFmpeg-devel] [PATCH v3 0/5] avcodec/dovi - disable metadata compression by default
Date: Tue, 18 Jun 2024 21:21:27 +0200
Message-ID: <20240618212127.GC9153@haasn.xyz> (raw)
In-Reply-To: <0101018fa7012ca1-8218ead9-5e49-46dd-8ad4-35eeddbc1cdf-000000@us-west-2.amazonses.com>
On Thu, 23 May 2024 19:50:23 +0000 Cosmin Stejerean via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> From: Cosmin Stejerean <cosmin@cosmin.at>
>
> not all clients support metadata compression, output when vdr_dm_metadata_changed fails the DV verifier.
>
> Compared to v2 this makes the dovi field name a parameter of the
> DOVI_ENCODING_OPTS macro as requested. It also splits up the commits into
> introducing the macro, guarding compression by it, and then leveraging it in
> the encoder.
>
> I split up each encoder into a separate patch since the original support was
> added in separate patches but this could also be squashed when applying if
> that's better.
>
> Cosmin Stejerean (5):
> avcodec/dovi_rpu - add field to disable metadata compression
> avcodec/dovi_rpuenc - guard metadata compression by enable_compression
> avcodec/libaomenc - switch DolbyVision options to DOVI_ENCODING_OPTS
> avcodec/libsvtav1 - switch DolbyVision options to DOVI_ENCODING_OPTS
> avcodec/libx265 - switch DolbyVision options to DOVI_ENCODING_OPTS
>
> libavcodec/dovi_rpu.h | 10 ++++++++++
> libavcodec/dovi_rpuenc.c | 8 ++++++--
> libavcodec/libaomenc.c | 3 +--
> libavcodec/libsvtav1.c | 3 +--
> libavcodec/libx265.c | 3 +--
> 5 files changed, 19 insertions(+), 8 deletions(-)
>
> --
> 2.42.1
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
I suppose this series is redundant now with the compression changes from
my BSF patchset?
Unless we want to preserve the macro for purely stylistic reasons, but
we can probably stomach the duplication of only a single option field.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-18 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240523195019.64019-1-cosmin@cosmin.at>
2024-05-23 19:50 ` Cosmin Stejerean via ffmpeg-devel
2024-06-18 19:21 ` Niklas Haas [this message]
[not found] ` <7CD3ACDC-B8C6-433C-8122-7BE26306B1E8@cosmin.at>
2024-06-20 14:41 ` Cosmin Stejerean via ffmpeg-devel
[not found] ` <20240523195019.64019-3-cosmin@cosmin.at>
2024-05-23 19:50 ` [FFmpeg-devel] [PATCH v3 2/5] avcodec/dovi_rpuenc - guard metadata compression Cosmin Stejerean via ffmpeg-devel
[not found] ` <20240523195019.64019-2-cosmin@cosmin.at>
2024-05-23 19:50 ` [FFmpeg-devel] [PATCH v3 1/5] avcodec/dovi_rpu - field and macro for " Cosmin Stejerean via ffmpeg-devel
[not found] ` <20240523195019.64019-4-cosmin@cosmin.at>
2024-05-23 19:50 ` [FFmpeg-devel] [PATCH v3 3/5] avcodec/libaomenc - switch to DOVI_ENCODING_OPTS Cosmin Stejerean via ffmpeg-devel
[not found] ` <20240523195019.64019-6-cosmin@cosmin.at>
2024-05-23 19:50 ` [FFmpeg-devel] [PATCH v3 5/5] avcodec/libx265 " Cosmin Stejerean via ffmpeg-devel
[not found] ` <20240523195019.64019-5-cosmin@cosmin.at>
2024-05-23 19:50 ` [FFmpeg-devel] [PATCH v3 4/5] avcodec/libsvtav1 " Cosmin Stejerean via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618212127.GC9153@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=cosmin@cosmin.at \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git