[FFmpeg-devel] [PATCH 1/2] avformat/evc: remove useless struct field

[FFmpeg-devel] [PATCH 1/2] avformat/evc: remove useless struct field

[James Almer]

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/evc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavformat/evc.c b/libavformat/evc.c
index 0b72a6441e..928ae1ff65 100644
--- a/libavformat/evc.c
+++ b/libavformat/evc.c
@@ -60,7 +60,6 @@ typedef struct EVCDecoderConfigurationRecord {
     uint8_t  bit_depth_chroma_minus8;       // 3 bits
     uint16_t pic_width_in_luma_samples;     // 16 bits
     uint16_t pic_height_in_luma_samples;    // 16 bits
-    uint8_t  reserved;                      // 6 bits '000000'b
     uint8_t  lengthSizeMinusOne;            // 2 bits
     uint8_t  num_of_arrays;                 // 8 bits
     EVCNALUnitArray arrays[NB_ARRAYS];
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] avformat/evc: fix writing reserved bits

[James Almer]

They are all zeroes, no ones.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/evc.c           | 4 ++--
 tests/ref/lavf-fate/evc.mp4 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavformat/evc.c b/libavformat/evc.c
index 928ae1ff65..ff350aad21 100644
--- a/libavformat/evc.c
+++ b/libavformat/evc.c
@@ -257,10 +257,10 @@ static int evcc_write(AVIOContext *pb, EVCDecoderConfigurationRecord *evcc)
     avio_wb16(pb, evcc->pic_height_in_luma_samples);
 
     /*
-     * bit(6) reserved = '111111'b;
+     * unsigned int(6) reserved = '000000'b;
      * unsigned int(2) chromaFormat;
      */
-    avio_w8(pb, evcc->lengthSizeMinusOne | 0xfc);
+    avio_w8(pb, evcc->lengthSizeMinusOne);
 
     /* unsigned int(8) numOfArrays; */
     avio_w8(pb, evcc->num_of_arrays);
diff --git a/tests/ref/lavf-fate/evc.mp4 b/tests/ref/lavf-fate/evc.mp4
index 4b410b84f3..6ef7af4ddc 100644
--- a/tests/ref/lavf-fate/evc.mp4
+++ b/tests/ref/lavf-fate/evc.mp4
@@ -1,3 +1,3 @@
-885fb330b20632b88ef9d7fb03dfa2e9 *tests/data/lavf-fate/lavf.evc.mp4
+bebb66fc3e13ece081d1aa96802e3c1f *tests/data/lavf-fate/lavf.evc.mp4
 37386 tests/data/lavf-fate/lavf.evc.mp4
 tests/data/lavf-fate/lavf.evc.mp4 CRC=0x48063f85
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".