From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 2/2] avformat/evc: fix writing reserved bits Date: Mon, 17 Jun 2024 11:21:20 -0300 Message-ID: <20240617142120.1476-2-jamrial@gmail.com> (raw) In-Reply-To: <20240617142120.1476-1-jamrial@gmail.com> They are all zeroes, no ones. Signed-off-by: James Almer <jamrial@gmail.com> --- libavformat/evc.c | 4 ++-- tests/ref/lavf-fate/evc.mp4 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/evc.c b/libavformat/evc.c index 928ae1ff65..ff350aad21 100644 --- a/libavformat/evc.c +++ b/libavformat/evc.c @@ -257,10 +257,10 @@ static int evcc_write(AVIOContext *pb, EVCDecoderConfigurationRecord *evcc) avio_wb16(pb, evcc->pic_height_in_luma_samples); /* - * bit(6) reserved = '111111'b; + * unsigned int(6) reserved = '000000'b; * unsigned int(2) chromaFormat; */ - avio_w8(pb, evcc->lengthSizeMinusOne | 0xfc); + avio_w8(pb, evcc->lengthSizeMinusOne); /* unsigned int(8) numOfArrays; */ avio_w8(pb, evcc->num_of_arrays); diff --git a/tests/ref/lavf-fate/evc.mp4 b/tests/ref/lavf-fate/evc.mp4 index 4b410b84f3..6ef7af4ddc 100644 --- a/tests/ref/lavf-fate/evc.mp4 +++ b/tests/ref/lavf-fate/evc.mp4 @@ -1,3 +1,3 @@ -885fb330b20632b88ef9d7fb03dfa2e9 *tests/data/lavf-fate/lavf.evc.mp4 +bebb66fc3e13ece081d1aa96802e3c1f *tests/data/lavf-fate/lavf.evc.mp4 37386 tests/data/lavf-fate/lavf.evc.mp4 tests/data/lavf-fate/lavf.evc.mp4 CRC=0x48063f85 -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-17 14:21 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-17 14:21 [FFmpeg-devel] [PATCH 1/2] avformat/evc: remove useless struct field James Almer 2024-06-17 14:21 ` James Almer [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240617142120.1476-2-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git