Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 4/9] avformat/iamf_parse: Layer, thou shalt not be 0
Date: Mon, 17 Jun 2024 01:08:26 +0200
Message-ID: <20240616230831.912377-4-michael@niedermayer.cc> (raw)
In-Reply-To: <20240616230831.912377-1-michael@niedermayer.cc>

Fixes: out of array access
Fixes: 68302/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4665793796177920

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/iamf_parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c
index 5c2ff6862a7..12c2b9533a8 100644
--- a/libavformat/iamf_parse.c
+++ b/libavformat/iamf_parse.c
@@ -330,7 +330,7 @@ static int scalable_channel_layout_config(void *s, AVIOContext *pb,
     nb_layers = avio_r8(pb) >> 5; // get_bits(&gb, 3);
     // skip_bits(&gb, 5); //reserved
 
-    if (nb_layers > 6)
+    if (nb_layers > 6 || nb_layers == 0)
         return AVERROR_INVALIDDATA;
 
     audio_element->layers = av_calloc(nb_layers, sizeof(*audio_element->layers));
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-06-16 23:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16 23:08 [FFmpeg-devel] [PATCH 1/9] avcodec/targaenc: Allocate space for the palette Michael Niedermayer
2024-06-16 23:08 ` [FFmpeg-devel] [PATCH 2/9] avcodec/mpeg4audio: Check that there is enough space for the first 3 elements in ff_mpeg4audio_get_config_gb() Michael Niedermayer
2024-06-17  5:27   ` Andreas Rheinhardt
2024-06-18 22:00     ` Michael Niedermayer
2024-06-16 23:08 ` [FFmpeg-devel] [PATCH 3/9] avformat/iamf_parse: Try to use less space after the array Michael Niedermayer
2024-06-18  0:35   ` James Almer
2024-06-19 10:54     ` Michael Niedermayer
2024-06-16 23:08 ` Michael Niedermayer [this message]
2024-06-18  0:33   ` [FFmpeg-devel] [PATCH 4/9] avformat/iamf_parse: Layer, thou shalt not be 0 James Almer
2024-06-19 10:57     ` Michael Niedermayer
2024-06-16 23:08 ` [FFmpeg-devel] [PATCH 5/9] avformat/mov: Check extend and base offset Michael Niedermayer
2024-06-18  0:41   ` James Almer
2024-06-18  7:07   ` Rémi Denis-Courmont
2024-06-18  7:10     ` Andreas Rheinhardt
2024-06-19 12:34     ` James Almer
2024-06-19 13:08       ` Rémi Denis-Courmont
2024-06-20 22:54         ` Michael Niedermayer
2024-06-20 22:58           ` James Almer
2024-06-16 23:08 ` [FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error Michael Niedermayer
2024-06-17 17:10   ` James Zern via ffmpeg-devel
2024-06-19 10:59     ` Michael Niedermayer
2024-06-16 23:08 ` [FFmpeg-devel] [PATCH 7/9] MAINTAINERS: Update the entries for the release maintainer for FFmpeg Michael Niedermayer
2024-06-17  7:07   ` Anton Khirnov
2024-06-17 23:48     ` Michael Niedermayer
2024-06-18 10:09       ` Anton Khirnov
2024-06-19 11:22         ` Michael Niedermayer
2024-06-17  7:26   ` Paul B Mahol
2024-06-18  7:02   ` Rémi Denis-Courmont
2024-06-18  9:53   ` Steven Liu
2024-06-18  9:56     ` Steven Liu
2024-06-16 23:08 ` [FFmpeg-devel] [PATCH 8/9] avcodec/smcenc: width < 4 is unsupported Michael Niedermayer
2024-06-17  7:50   ` Paul B Mahol
2024-06-17 23:52     ` Michael Niedermayer
2024-06-18  7:42       ` Paul B Mahol
2024-06-25 19:56         ` Michael Niedermayer
2024-06-16 23:08 ` [FFmpeg-devel] [PATCH 9/9] avcodec/r210enc: Use av_rescale for bitrate Michael Niedermayer
2024-06-25 19:54   ` Michael Niedermayer
2024-06-25 19:55 ` [FFmpeg-devel] [PATCH 1/9] avcodec/targaenc: Allocate space for the palette Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240616230831.912377-4-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git