Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: [FFmpeg-devel] [PATCH 3/6] aacdec_ac: fix an overread
Date: Sun, 16 Jun 2024 10:54:45 +0200
Message-ID: <20240616085454.2560973-3-dev@lynne.ee> (raw)
In-Reply-To: <20240616085454.2560973-1-dev@lynne.ee>

Fixes reading state->last[i + 1] in ff_aac_ac_get_context for the
last array member.
---
 libavcodec/aac/aacdec_ac.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/aac/aacdec_ac.h b/libavcodec/aac/aacdec_ac.h
index 0b98c0f0d9..b8d4ade4c6 100644
--- a/libavcodec/aac/aacdec_ac.h
+++ b/libavcodec/aac/aacdec_ac.h
@@ -25,7 +25,7 @@
 #include "libavcodec/get_bits.h"
 
 typedef struct AACArithState {
-    uint8_t last[512 /* 2048 / 4 */];
+    uint8_t last[512 /* 2048 / 4 */ + 1];
     int last_len;
     uint8_t cur[4];
     uint16_t state_pre;
-- 
2.45.1.288.g0e0cd299f1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-06-16  8:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16  8:54 [FFmpeg-devel] [PATCH 1/6] aacdec_usac: apply specification fix M55715 Lynne via ffmpeg-devel
2024-06-16  8:54 ` [FFmpeg-devel] [PATCH 2/6] aac: expose ff_aac_sample_rate_idx() in aac.h Lynne via ffmpeg-devel
2024-06-16  8:54 ` Lynne via ffmpeg-devel [this message]
2024-06-16  8:54 ` [FFmpeg-devel] [PATCH 4/6] aacdec_usac: rename noise_scale to noise_bands Lynne via ffmpeg-devel
2024-06-16  8:54 ` [FFmpeg-devel] [PATCH 5/6] aacdec_usac: remove custom rate_idx and use standard variable for it Lynne via ffmpeg-devel
2024-06-16  8:54 ` [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC Lynne via ffmpeg-devel
2024-06-17  7:35   ` Anton Khirnov
2024-06-17 19:01     ` Lynne via ffmpeg-devel
2024-06-17 19:04       ` Lynne via ffmpeg-devel
2024-06-26  7:29         ` Anton Khirnov
2024-06-20  2:12   ` Lynne via ffmpeg-devel
2024-06-23  7:11     ` Lynne via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240616085454.2560973-3-dev@lynne.ee \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=dev@lynne.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git