[FFmpeg-devel] [PATCH] avcodec/aaccoder_twoloop: remove unread max scaler

[FFmpeg-devel] [PATCH] avcodec/aaccoder_twoloop: remove unread max scaler

[Yotam Ofek]

---
 libavcodec/aaccoder_twoloop.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h
index c1dcdbb5ed..c56abc68a7 100644
--- a/libavcodec/aaccoder_twoloop.h
+++ b/libavcodec/aaccoder_twoloop.h
@@ -101,7 +101,7 @@ static void search_for_quantizers_twoloop(AVCodecContext *avctx,
      */
     float sfoffs = av_clipf(log2f(120.0f / lambda) * 4.0f, -5, 10);
 
-    int fflag, minscaler, maxscaler, nminscaler;
+    int fflag, minscaler, nminscaler;
     int its  = 0;
     int maxits = 30;
     int allz = 0;
@@ -572,12 +572,10 @@ static void search_for_quantizers_twoloop(AVCodecContext *avctx,
         }
 
         minscaler = SCALE_MAX_POS;
-        maxscaler = 0;
         for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w]) {
             for (g = 0;  g < sce->ics.num_swb; g++) {
                 if (!sce->zeroes[w*16+g]) {
                     minscaler = FFMIN(minscaler, sce->sf_idx[w*16+g]);
-                    maxscaler = FFMAX(maxscaler, sce->sf_idx[w*16+g]);
                 }
             }
         }
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/aaccoder_twoloop: remove unread max scaler

[Yotam Ofek]

Bump :)

On Fri, Jun 14, 2024, 13:21 Yotam Ofek <yotam.ofek@gmail.com> wrote:

> ---
>  libavcodec/aaccoder_twoloop.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h
> index c1dcdbb5ed..c56abc68a7 100644
> --- a/libavcodec/aaccoder_twoloop.h
> +++ b/libavcodec/aaccoder_twoloop.h
> @@ -101,7 +101,7 @@ static void
> search_for_quantizers_twoloop(AVCodecContext *avctx,
>       */
>      float sfoffs = av_clipf(log2f(120.0f / lambda) * 4.0f, -5, 10);
>
> -    int fflag, minscaler, maxscaler, nminscaler;
> +    int fflag, minscaler, nminscaler;
>      int its  = 0;
>      int maxits = 30;
>      int allz = 0;
> @@ -572,12 +572,10 @@ static void
> search_for_quantizers_twoloop(AVCodecContext *avctx,
>          }
>
>          minscaler = SCALE_MAX_POS;
> -        maxscaler = 0;
>          for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w])
> {
>              for (g = 0;  g < sce->ics.num_swb; g++) {
>                  if (!sce->zeroes[w*16+g]) {
>                      minscaler = FFMIN(minscaler, sce->sf_idx[w*16+g]);
> -                    maxscaler = FFMAX(maxscaler, sce->sf_idx[w*16+g]);
>                  }
>              }
>          }
> --
> 2.40.1
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/aaccoder_twoloop: remove unread max scaler

[Lynne via ffmpeg-devel]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1296 bytes --]

On 14/06/2024 12:21, Yotam Ofek wrote:
> ---
>   libavcodec/aaccoder_twoloop.h | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h
> index c1dcdbb5ed..c56abc68a7 100644
> --- a/libavcodec/aaccoder_twoloop.h
> +++ b/libavcodec/aaccoder_twoloop.h
> @@ -101,7 +101,7 @@ static void search_for_quantizers_twoloop(AVCodecContext *avctx,
>        */
>       float sfoffs = av_clipf(log2f(120.0f / lambda) * 4.0f, -5, 10);
>   
> -    int fflag, minscaler, maxscaler, nminscaler;
> +    int fflag, minscaler, nminscaler;
>       int its  = 0;
>       int maxits = 30;
>       int allz = 0;
> @@ -572,12 +572,10 @@ static void search_for_quantizers_twoloop(AVCodecContext *avctx,
>           }
>   
>           minscaler = SCALE_MAX_POS;
> -        maxscaler = 0;
>           for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w]) {
>               for (g = 0;  g < sce->ics.num_swb; g++) {
>                   if (!sce->zeroes[w*16+g]) {
>                       minscaler = FFMIN(minscaler, sce->sf_idx[w*16+g]);
> -                    maxscaler = FFMAX(maxscaler, sce->sf_idx[w*16+g]);
>                   }
>               }
>           }

Thanks, pushed both patches.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".