From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ECBBF48296 for ; Thu, 13 Jun 2024 21:11:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C7C6868DA82; Fri, 14 Jun 2024 00:11:27 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C02F768DA45 for ; Fri, 14 Jun 2024 00:11:20 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 246C540002 for ; Thu, 13 Jun 2024 21:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718313080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PtEkkoUB9Pk+XRWfdM1S3/eoe67Zg/ZcpeUJVTokIE=; b=SjCRbiKhuS6ChYOmNIY2i0hMMihWMKUStjLZT+63e4R4reoiShBUOG6HS4+36VTaHmv3I/ aEN+TceU2lnLLIQNEzRUojNAtEGYBVLxr/UYI0do/QHuzR0n5kp8Gj5mJxaA4uB4dq6+2T A7DMXl8vWWimGAIZhBpligr4BXLy9YHot5WORwjW9B+NR71adWaI/6nlEjjjsLUBup23mu BMoksj/kNC8OmuN2xSYpK39kBu7vSykaQaJSHGcjz3WD5XDbh3O+plKHUOoaPNdHf1pv/D 5kRleh6SukyLEfhbJnSfrUyVik46f2nk1RPJjR6ASxbNDYkePktd+/0Mibo8gQ== Date: Thu, 13 Jun 2024 23:11:18 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240613211118.GH2821752@pb2> References: <20240613074920.GC2821752@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 25/57] avcodec/me_cmp, motion_est: Sanitize permissible cmp_funcs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0074883248975773280==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0074883248975773280== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9NAd1yhFnES4Uni3" Content-Disposition: inline --9NAd1yhFnES4Uni3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 13, 2024 at 11:37:13AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Jun 12, 2024 at 03:48:21PM +0200, Andreas Rheinhardt wrote: > >> Several of the potential choices of comparison functions > >> need an initialized MpegEncContext (initialized for encoding, > >> not only ff_mpv_common_init()) or they crash when called. > >> Modify ff_set_cmp() to check for this. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >=20 > > I dont think they always crashed, so to me marking these as > > unsupported now feels a bit strange. But it shows we where lacking > > testing >=20 > Why don't you just try: > for codec in svq1 snow; do for cmp in dct psnr bit rd dctmax 14; do > ./ffmpeg_g -hide_banner -filter_complex nullsrc -c:v "$codec" -cmp > "$cmp" -f null -; done; done > yourself? I did misread your patch, i thought you where disabling them for all cases. Yes svq1 & snow probably didnt work with them thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad --9NAd1yhFnES4Uni3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZmtgcwAKCRBhHseHBAsP q4VFAJ9wg0wPYqqrMUMtbMbTfSEaqHi6cQCfYcgZh/HSkEBwKNT00G2x600mFfU= =JaXF -----END PGP SIGNATURE----- --9NAd1yhFnES4Uni3-- --===============0074883248975773280== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0074883248975773280==--