From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 743114B79F for ; Thu, 13 Jun 2024 08:23:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 874C768D96C; Thu, 13 Jun 2024 11:23:33 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8A0C768D8AD for ; Thu, 13 Jun 2024 11:23:26 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E113B24000A for ; Thu, 13 Jun 2024 08:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718267006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zrOWPO/SotEq/U/ifo/ZGjs67lnuMyxb6ywu6vPsGcI=; b=VmvNe6HKqGWHaxj0GRnVUidv37+boiD67HNyleqbLSKD19DyyeVzpbjFB8OrXJGtq0RuWN yfmvOUjHMCdKKI2y92towWiaY5LlwTkEuZN+3jdX9l37Kc1dv/AFsiReSyehAUu+PZT87t gNiGahtku6HEc8dgKr6O+P/7Lk4HVKXHOM5VGVMOS53DuwaQC4Sh6rVirv0VzkCIdd3eFd 1tGQ6B/5o0YbJioYfQyq2/AHa1sI/azedvTOVeZ/+DrZj7RDvQjkpfj+W7SRLKZaWfqCum WgLcHb7AXyYkEHoly4VQ4zMiZm9hgwY5wgqo4/CCaGH1LdfsMeX/eo6NniVM9g== Date: Thu, 13 Jun 2024 10:23:25 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240613082325.GD2821752@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 12/57] avcodec/mpegutils: Don't use MB_TYPE_L[01] for mpegvideo X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2431422335767933932==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2431422335767933932== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yDeUtHrhrK5kRdq+" Content-Disposition: inline --yDeUtHrhrK5kRdq+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 12, 2024 at 03:48:08PM +0200, Andreas Rheinhardt wrote: > MB_TYPE_L[01] is based upon H.264 terminology (it stands for > list); yet the mpegvideo based decoders don't have lists > of reference frames, they have at most one forward and one > backward reference. So use terminology based upon this. >=20 > This also has a second advantage: MB_TYPE_L[01] is actually > an OR of two flags (which are set independently for H.264, > but aren't for mpegvideo). Switching to different flags > makes the flags fit into an int16_t, which will be useful > in future commits. >=20 > The only downside to this is a very small amount of code > in error_resilience.c and mpegutils.c (the only code shared > between the H.264 decoder and mpegvideo). Cant you just call the flags differently but leave them nummerically the same, if you dont like L0L1 terminology ? Having each codec be different does not seem to me to be a good thing It adds burden to every bit of common code. It may be thats error_resilience ATM, but there are other things people may want to add, like an universal encoder for all the block based transform + MC formats thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --yDeUtHrhrK5kRdq+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZmqseQAKCRBhHseHBAsP q+OFAJ4o15joyI04IErND8dInv8hHpafHgCbBsSskmPdcRODKok0wp2ktWJZimI= =qOk6 -----END PGP SIGNATURE----- --yDeUtHrhrK5kRdq+-- --===============2431422335767933932== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2431422335767933932==--