From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function
Date: Wed, 12 Jun 2024 07:47:21 +0300
Message-ID: <20240612044723.175502-2-remi@remlab.net> (raw)
In-Reply-To: <20240612044723.175502-1-remi@remlab.net>
---
configure | 4 ++--
libavcodec/mpegvideo.c | 46 +++++++++++-------------------------------
2 files changed, 14 insertions(+), 36 deletions(-)
diff --git a/configure b/configure
index 6baa9b0646..eb9d1b1f5d 100755
--- a/configure
+++ b/configure
@@ -2957,8 +2957,8 @@ ftr_decoder_select="adts_header"
g2m_decoder_deps="zlib"
g2m_decoder_select="blockdsp idctdsp jpegtables"
g729_decoder_select="audiodsp"
-h261_decoder_select="mpegvideodec"
-h261_encoder_select="mpegvideoenc"
+h261_decoder_select="h263dsp mpegvideodec"
+h261_encoder_select="h263dsp mpegvideoenc"
h263_decoder_select="h263_parser h263dsp mpegvideodec qpeldsp"
h263_encoder_select="h263dsp mpegvideoenc"
h263i_decoder_select="h263_decoder"
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 7af823b8bd..b35fd37083 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -201,13 +201,11 @@ static void dct_unquantize_mpeg2_inter_c(MpegEncContext *s,
static void dct_unquantize_h263_intra_c(MpegEncContext *s,
int16_t *block, int n, int qscale)
{
- int i, level, qmul, qadd;
- int nCoeffs;
+ int qmul = qscale << 1;
+ int qadd, nCoeffs;
av_assert2(s->block_last_index[n]>=0 || s->h263_aic);
- qmul = qscale << 1;
-
if (!s->h263_aic) {
block[0] *= n < 4 ? s->y_dc_scale : s->c_dc_scale;
qadd = (qscale - 1) | 1;
@@ -215,47 +213,24 @@ static void dct_unquantize_h263_intra_c(MpegEncContext *s,
qadd = 0;
}
if(s->ac_pred)
- nCoeffs=63;
+ nCoeffs = 64;
else
- nCoeffs= s->intra_scantable.raster_end[ s->block_last_index[n] ];
+ nCoeffs = s->intra_scantable.raster_end[s->block_last_index[n]] + 1;
- for(i=1; i<=nCoeffs; i++) {
- level = block[i];
- if (level) {
- if (level < 0) {
- level = level * qmul - qadd;
- } else {
- level = level * qmul + qadd;
- }
- block[i] = level;
- }
- }
+ s->h263dsp.h263_dct_unquantize_intra(block, nCoeffs, qmul, qadd);
}
static void dct_unquantize_h263_inter_c(MpegEncContext *s,
int16_t *block, int n, int qscale)
{
- int i, level, qmul, qadd;
+ int qmul = qscale << 1;
+ int qadd = (qscale - 1) | 1;
int nCoeffs;
av_assert2(s->block_last_index[n]>=0);
- qadd = (qscale - 1) | 1;
- qmul = qscale << 1;
-
- nCoeffs= s->inter_scantable.raster_end[ s->block_last_index[n] ];
-
- for(i=0; i<=nCoeffs; i++) {
- level = block[i];
- if (level) {
- if (level < 0) {
- level = level * qmul - qadd;
- } else {
- level = level * qmul + qadd;
- }
- block[i] = level;
- }
- }
+ nCoeffs = s->inter_scantable.raster_end[s->block_last_index[n]] + 1;
+ s->h263dsp.h263_dct_unquantize_inter(block, nCoeffs, qmul, qadd);
}
@@ -275,6 +250,9 @@ static void gray8(uint8_t *dst, const uint8_t *src, ptrdiff_t linesize, int h)
static av_cold int dct_init(MpegEncContext *s)
{
ff_blockdsp_init(&s->bdsp);
+#if CONFIG_H263DSP
+ ff_h263dsp_init(&s->h263dsp);
+#endif
ff_hpeldsp_init(&s->hdsp, s->avctx->flags);
ff_videodsp_init(&s->vdsp, s->avctx->bits_per_raw_sample);
--
2.45.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-12 4:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 4:47 [FFmpeg-devel] [PATCHv5 1/4] lavc/h263dsp: add DCT dequantisation functions Rémi Denis-Courmont
2024-06-12 4:47 ` Rémi Denis-Courmont [this message]
2024-06-14 14:33 ` [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function James Almer
2024-06-14 14:45 ` Rémi Denis-Courmont
2024-06-14 15:11 ` Rémi Denis-Courmont
2024-06-14 15:41 ` James Almer
2024-06-14 19:03 ` Rémi Denis-Courmont
2024-06-12 4:47 ` [FFmpeg-devel] [PATCH 3/4] checkasm/h263dsp: test dct_unquantize_{intra, inter} Rémi Denis-Courmont
2024-06-12 18:39 ` James Almer
2024-06-12 19:15 ` Rémi Denis-Courmont
2024-06-12 19:39 ` James Almer
2024-06-12 19:52 ` Rémi Denis-Courmont
2024-06-13 19:41 ` [FFmpeg-devel] [PATCHv6 " Rémi Denis-Courmont
2024-06-12 4:47 ` [FFmpeg-devel] [PATCH 4/4] lavc/h263dsp: R-V V " Rémi Denis-Courmont
2024-06-13 19:41 ` [FFmpeg-devel] [PATCHv6 " Rémi Denis-Courmont
2024-06-12 17:40 ` [FFmpeg-devel] [PATCHv5 1/4] lavc/h263dsp: add DCT dequantisation functions James Almer
2024-06-12 18:10 ` Rémi Denis-Courmont
2024-06-13 2:23 ` Andreas Rheinhardt
2024-06-13 19:22 ` Rémi Denis-Courmont
-- strict thread matches above, loose matches on Subject: below --
2024-07-01 19:13 [FFmpeg-devel] [PATCH " Rémi Denis-Courmont
2024-07-01 19:13 ` [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function Rémi Denis-Courmont
2024-07-06 15:23 ` Andreas Rheinhardt
2024-07-06 16:10 ` Rémi Denis-Courmont
2024-07-06 16:20 ` Andreas Rheinhardt
2024-07-06 16:47 ` Rémi Denis-Courmont
2024-07-06 18:27 ` Andreas Rheinhardt
2024-06-09 16:23 [FFmpeg-devel] [PATCHv3 1/4] lavc/h263dsp: add DCT dequantisation functions Rémi Denis-Courmont
2024-06-09 16:23 ` [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function Rémi Denis-Courmont
2024-06-10 11:41 ` Michael Niedermayer
2024-06-10 12:14 ` Rémi Denis-Courmont
2024-06-10 12:32 ` Michael Niedermayer
2024-06-09 9:27 [FFmpeg-devel] [PATCHv2 1/4] lavc/h263dsp: add DCT dequantisation function Rémi Denis-Courmont
2024-06-09 9:27 ` [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function Rémi Denis-Courmont
2024-06-09 16:13 ` Andreas Rheinhardt
2024-06-09 16:39 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612044723.175502-2-remi@remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git