From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A04FC4B6C6 for ; Tue, 11 Jun 2024 16:04:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 64CD968D6AB; Tue, 11 Jun 2024 19:04:25 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CC59568D75A for ; Tue, 11 Jun 2024 19:04:18 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0F90920009 for ; Tue, 11 Jun 2024 16:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718121858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fWW0Rdj1oBnSn0JnQa1mav+MuWSXZXRuiOLCYGC+2fM=; b=adFvn8iTB+R9qjTL2Q1Scm8Nzij7/DCfS5BMFOvLNLQoy7KztrHebDVXR3exLF3t20ylmC jCILnC/yR5svQi03PvKXCgpz9xe41zJb6IJFsoskrXKtj6YohJgxNNjjzoplje7nd0sdUq 2Ogpoc0rKXHwAgOzHxF/3iFle/+2TC8XKGdL/A4YaegX1BKMIlCAAIGuFhzV/jzDoDh/c8 7c8sy9B9la7QWqegxtNotfjTSHf8pqoZdY/VwI43SYR3CAZOWAJ6qIE+xxJjiQoyKUluqj NUTJrx7DFIcHJ8vUztKVAJsZUgm448MC0WCbIfqqgkVo6Zh+QqzfpW62gYSK8g== Date: Tue, 11 Jun 2024 18:04:17 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240611160417.GM2821752@pb2> References: <20240607181947.330026-1-remi@remlab.net> <20240611131519.GI2821752@pb2> <3716975.pXSbhMsudd@basile.remlab.net> MIME-Version: 1.0 In-Reply-To: <3716975.pXSbhMsudd@basile.remlab.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/bswap: remove some inline assembler X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6054665417189980857==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6054665417189980857== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B1uqtiWsYrJca04Z" Content-Disposition: inline --B1uqtiWsYrJca04Z Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2024 at 06:28:30PM +0300, R=E9mi Denis-Courmont wrote: > Le tiistaina 11. kes=E4kuuta 2024, 16.15.19 EEST Michael Niedermayer a = =E9crit : > > On Fri, Jun 07, 2024 at 09:19:46PM +0300, R=E9mi Denis-Courmont wrote: > > > C code or compiler built-ins are preferable over inline assembler for > > > byte-swaps as it allows for better optimisations (e.g. instruction > > > scheduling) which would otherwise be impossible. > > >=20 > > > As with f64c2e710fa1a7b59753224e717f57c48462076f for x86 and Arm, > > > this removes the inline assembler on GCC (and Clang) since we now > > > require recent enough compiler versions (this indeed seems to work on > > > AArch64). > > > --- > > >=20 > > > libavutil/aarch64/bswap.h | 56 -------------------------------------= -- > > > libavutil/avr32/bswap.h | 44 ------------------------------ > > > libavutil/bswap.h | 8 +----- > > > libavutil/sh4/bswap.h | 48 --------------------------------- > >=20 > > As you are writing that this preferrable for better optimisations > > Please provide benchmarks (for sh4, avr32) >=20 > How would someone benchmark an architecture like AVR32 that is not just d= ead=20 > but barely even commercially existed at all, and for which there exist no= =20 > known C11 compiler and thus cannot even compile FFmpeg? then simply remove avr32 with that explanation (no C11 compiler, and any ot= her reason) but if a commit message says the code is removed because that "allows for b= etter optimisations" then yes i ask for benchmarks thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --B1uqtiWsYrJca04Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZmh1gQAKCRBhHseHBAsP q1qhAKCJLwMJdUKhDP80dz/T+uWeYU/TZgCePNlG0hTjEfvEfk6R7R9VQBv54eU= =DIi/ -----END PGP SIGNATURE----- --B1uqtiWsYrJca04Z-- --===============6054665417189980857== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6054665417189980857==--