From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7D3454B6C1 for ; Tue, 11 Jun 2024 15:57:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6ED1968D888; Tue, 11 Jun 2024 18:57:30 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A068968D7FE for ; Tue, 11 Jun 2024 18:57:23 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id F2D721C000C for ; Tue, 11 Jun 2024 15:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718121443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LUa964zX+yQ9h/cBM6FE2iNIguPz5n04yVwBj1QQ6vU=; b=ldMaRvWzcKEx0k+nI5vtNfK1D74WKYrlQi4J+pgmgaPRf4uwn9edQGO6DjZ7GmkC98nieN bStInzbTzsLXp+NXbtht/74UaOly9C3blpXqVrd8e9o9EiJNC8e5U0J80SBNQenRkzdtts 1mHP9ftYqFgWGbyuNYUMPFPHbL1B+8IF5hHXCsWPTyhOd/I5PWw3aP1vgZYb2irZQTsgAG kpVG2kYhFmD0DSgiF7U6kgubE8yJHiNlfuGHXVPCk0Q380GpGlKKzY0wGYSjm19J299wbM MamET72jfgcoReats2xXnuCJ9hWBr3Dakyzdbqwfk98Z2yKa8AIZFBZYPYqo8w== Date: Tue, 11 Jun 2024 17:57:21 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240611155721.GL2821752@pb2> References: <20240607181947.330026-1-remi@remlab.net> <20240611131519.GI2821752@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/bswap: remove some inline assembler X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5890437225860019180==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5890437225860019180== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hIOUAZgQFgkU+/gn" Content-Disposition: inline --hIOUAZgQFgkU+/gn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2024 at 12:38:37PM -0300, James Almer wrote: > On 6/11/2024 10:15 AM, Michael Niedermayer wrote: > > On Fri, Jun 07, 2024 at 09:19:46PM +0300, R=E9mi Denis-Courmont wrote: > > > C code or compiler built-ins are preferable over inline assembler for > > > byte-swaps as it allows for better optimisations (e.g. instruction > > > scheduling) which would otherwise be impossible. > > >=20 > > > As with f64c2e710fa1a7b59753224e717f57c48462076f for x86 and Arm, > > > this removes the inline assembler on GCC (and Clang) since we now > > > require recent enough compiler versions (this indeed seems to work on > > > AArch64). > > > --- > > > libavutil/aarch64/bswap.h | 56 ------------------------------------= --- > > > libavutil/avr32/bswap.h | 44 ------------------------------ > > > libavutil/bswap.h | 8 +----- > > > libavutil/sh4/bswap.h | 48 --------------------------------- > >=20 > > As you are writing that this preferrable for better optimisations > > Please provide benchmarks (for sh4, avr32) >=20 > This is a ridiculous request, considering nobody has such hardware at all. Then I think its a ridiculous claim that this optimizes the code I mean, at some point there was hardware and these optimisations did improve speed. This patch is not removing the code because its a rare (or dead) platform, = it removes it with the claim that this would "allows for better optimisations" Iam sorry but i do not see why asking for the claim in the commit message to be backed up with facts being ridiculous The claim in the commit message may be ridiculous thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle --hIOUAZgQFgkU+/gn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZmhz1wAKCRBhHseHBAsP q2tDAJ9wc87NebGwPDi0NCbikFWL8EJhEQCcCwudBe2BbEpgJ+rXcEHTNfVK/3E= =9Ecd -----END PGP SIGNATURE----- --hIOUAZgQFgkU+/gn-- --===============5890437225860019180== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5890437225860019180==--