From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C821B4B69F for ; Tue, 11 Jun 2024 14:55:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4635A68D861; Tue, 11 Jun 2024 17:55:13 +0300 (EEST) Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 35A0E68D777 for ; Tue, 11 Jun 2024 17:55:06 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 5B1B3C0172 for ; Tue, 11 Jun 2024 17:55:05 +0300 (EEST) From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 11 Jun 2024 17:55:04 +0300 Message-ID: <20240611145505.14934-2-remi@remlab.net> X-Mailer: git-send-email 2.45.1 In-Reply-To: <4929107.rjQTLOYEdK@basile.remlab.net> References: <4929107.rjQTLOYEdK@basile.remlab.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] checkasm/vc1dsp: check the not-in-place block content X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This seems to cause issues in FATE for 4x4 and 4x8 transforms. But then again, FATE does not seem to care in the 8x4 case. Note that AArch64 NEON code is known to fail this test. --- tests/checkasm/vc1dsp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c index f18f0f8251..2cc6785a0c 100644 --- a/tests/checkasm/vc1dsp.c +++ b/tests/checkasm/vc1dsp.c @@ -317,11 +317,13 @@ static void check_inv_trans_adding(void) for (int j = 0; j < tests[t].height; ++j) for (int i = 0; i < tests[t].width; ++i) { int idx = j * 8 + i; - inv_trans_in1[idx] = inv_trans_in0[idx] = coeffs->d[j * tests[t].width + i]; + inv_trans_in0[idx] = coeffs->d[j * tests[t].width + i]; } + memcpy(inv_trans_in1, inv_trans_in0, 8 * 8 * 2); call_ref(inv_trans_out0 + 24 + 8, 24, inv_trans_in0); call_new(inv_trans_out1 + 24 + 8, 24, inv_trans_in1); - if (memcmp(inv_trans_out0, inv_trans_out1, 10 * 24)) + if (memcmp(inv_trans_in0, inv_trans_in1, 8 * 8 * 2) || + memcmp(inv_trans_out0, inv_trans_out1, 10 * 24)) fail(); bench_new(inv_trans_out1 + 24 + 8, 24, inv_trans_in1 + 8); av_free(coeffs); -- 2.45.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".