From: "Rémi Denis-Courmont" <remi@remlab.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 2/2] checkasm/vc1dsp: check the not-in-place block content Date: Tue, 11 Jun 2024 17:55:04 +0300 Message-ID: <20240611145505.14934-2-remi@remlab.net> (raw) In-Reply-To: <4929107.rjQTLOYEdK@basile.remlab.net> This seems to cause issues in FATE for 4x4 and 4x8 transforms. But then again, FATE does not seem to care in the 8x4 case. Note that AArch64 NEON code is known to fail this test. --- tests/checkasm/vc1dsp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c index f18f0f8251..2cc6785a0c 100644 --- a/tests/checkasm/vc1dsp.c +++ b/tests/checkasm/vc1dsp.c @@ -317,11 +317,13 @@ static void check_inv_trans_adding(void) for (int j = 0; j < tests[t].height; ++j) for (int i = 0; i < tests[t].width; ++i) { int idx = j * 8 + i; - inv_trans_in1[idx] = inv_trans_in0[idx] = coeffs->d[j * tests[t].width + i]; + inv_trans_in0[idx] = coeffs->d[j * tests[t].width + i]; } + memcpy(inv_trans_in1, inv_trans_in0, 8 * 8 * 2); call_ref(inv_trans_out0 + 24 + 8, 24, inv_trans_in0); call_new(inv_trans_out1 + 24 + 8, 24, inv_trans_in1); - if (memcmp(inv_trans_out0, inv_trans_out1, 10 * 24)) + if (memcmp(inv_trans_in0, inv_trans_in1, 8 * 8 * 2) || + memcmp(inv_trans_out0, inv_trans_out1, 10 * 24)) fail(); bench_new(inv_trans_out1 + 24 + 8, 24, inv_trans_in1 + 8); av_free(coeffs); -- 2.45.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-11 14:55 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-10 19:03 [FFmpeg-devel] [PATCH] lavc/vc1dsp: match C block layout in inv_trans_4x4_rvv Rémi Denis-Courmont 2024-06-10 19:20 ` [FFmpeg-devel] [PATCH] lavc/vc1dsp: match C block layout in inv_trans_4x8_rvv Rémi Denis-Courmont 2024-06-11 12:09 ` Ronald S. Bultje 2024-06-11 12:19 ` Rémi Denis-Courmont 2024-06-11 12:23 ` James Almer 2024-06-11 14:53 ` Rémi Denis-Courmont 2024-06-11 14:55 ` [FFmpeg-devel] [PATCH 1/2] lavc/vc1dsp: match C block content in inv_trans_8x4_rvv Rémi Denis-Courmont 2024-06-11 14:55 ` Rémi Denis-Courmont [this message] 2024-06-11 15:08 ` [FFmpeg-devel] [PATCH 2/2] checkasm/vc1dsp: check the not-in-place block content James Almer 2024-06-11 15:34 ` Rémi Denis-Courmont
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240611145505.14934-2-remi@remlab.net \ --to=remi@remlab.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git