[FFmpeg-devel] [PATCH] avcodec/aacdec_lpd: remove unused local variables

[FFmpeg-devel] [PATCH] avcodec/aacdec_lpd: remove unused local variables

[Leo Izen]

int idx, and int first_tcx_flag are set but not used, so this commit
removes their declarations and assignments.

Signed-off-by: Leo Izen <leo.izen@gmail.com>
---
 libavcodec/aac/aacdec_lpd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c
index 796edd2ab5..5e9909e361 100644
--- a/libavcodec/aac/aacdec_lpd.c
+++ b/libavcodec/aac/aacdec_lpd.c
@@ -99,7 +99,7 @@ static void parse_qn(GetBitContext *gb, int *qn, int nk_mode, int no_qn)
 static int parse_codebook_idx(GetBitContext *gb, uint32_t *kv,
                               int nk_mode, int no_qn)
 {
-    int idx, n, nk;
+    int n, nk;
 
     int qn[2];
     parse_qn(gb, qn, nk_mode, no_qn);
@@ -145,7 +145,6 @@ int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac,
     int k;
     const uint8_t *mod;
     int first_ldp_flag;
-    int first_tcx_flag;
 
     ce->ldp.acelp_core_mode = get_bits(gb, 3);
     ce->ldp.lpd_mode = get_bits(gb, 5);
@@ -157,7 +156,6 @@ int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac,
     mod = ff_aac_lpd_mode_tab[ce->ldp.lpd_mode];
 
     first_ldp_flag = !ce->ldp.core_mode_last;
-    first_tcx_flag = 1;
     if (first_ldp_flag)
         ce->ldp.last_lpd_mode = -1; /* last_ldp_mode is a **STATEFUL** value */
 
@@ -179,7 +177,6 @@ int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac,
 //            parse_tcx_coding();
             ce->ldp.last_lpd_mode = mod[k];
             k += (1 << (mod[k] - 1));
-            first_tcx_flag = 0;
         }
     }
 
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_lpd: remove unused local variables

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1364 bytes --]

On Sat, Jun 08, 2024 at 08:17:54PM -0400, Leo Izen wrote:
> int idx, and int first_tcx_flag are set but not used, so this commit
> removes their declarations and assignments.
> 
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
>  libavcodec/aac/aacdec_lpd.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c
> index 796edd2ab5..5e9909e361 100644
> --- a/libavcodec/aac/aacdec_lpd.c
> +++ b/libavcodec/aac/aacdec_lpd.c
> @@ -99,7 +99,7 @@ static void parse_qn(GetBitContext *gb, int *qn, int nk_mode, int no_qn)
>  static int parse_codebook_idx(GetBitContext *gb, uint32_t *kv,
>                                int nk_mode, int no_qn)
>  {
> -    int idx, n, nk;
> +    int n, nk;
>  
>      int qn[2];
>      parse_qn(gb, qn, nk_mode, no_qn);

libavcodec/aac/aacdec_lpd.c: In function ‘parse_codebook_idx’:
libavcodec/aac/aacdec_lpd.c:117:5: error: ‘idx’ undeclared (first use in this function)
  117 |     idx = get_bits(gb, 4*n);
      |     ^~~

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".