From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 48BBD49D6F
	for <ffmpegdev@gitmailbox.com>; Sun,  9 Jun 2024 22:43:25 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BF3AF68D6EF;
	Mon, 10 Jun 2024 01:43:22 +0300 (EEST)
Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net
 [217.70.183.197])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 82BCC68D686
 for <ffmpeg-devel@ffmpeg.org>; Mon, 10 Jun 2024 01:43:16 +0300 (EEST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id D553C1C0002
 for <ffmpeg-devel@ffmpeg.org>; Sun,  9 Jun 2024 22:43:15 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1717972996;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=C8XkK7Dzec/SAupWtxR1b5KZ3sU27SGz0XvTd7BfKRc=;
 b=DUpWfXL9uyccg/3KcgGb7zUXlXFXto7nRFAXKOsaiHEXVvUA6acOZzpd6dx361KK0EHUzr
 Iy47H3n+wZV8n/ukclv8gESnMaf2uyxsc6l0k/POBWr4Tsw/1GcLY/iXONeVtDx0imtFlc
 7t8yBvk4Ob484pJzqYIECjgyXgZ5kDIa/ZlZf+IjH+chN5yp0fbrzTSJwmzE3sjM5CIhQV
 v6xi5alLxWBw8GHuHwrSlJvTU00AIaOXUoMUGeWr0Mqr9CYrjLgWuG433898BhGmKVUiaM
 XK0rMzMI/lUDUaAe4SpaRBtcSIYY3C7Y4F3FBHsOE45Q8EltqVMRZ1svwlS+Pw==
Date: Mon, 10 Jun 2024 00:43:14 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20240609224314.GA2821752@pb2>
References: <20240609001754.260928-1-leo.izen@gmail.com>
MIME-Version: 1.0
In-Reply-To: <20240609001754.260928-1-leo.izen@gmail.com>
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_lpd: remove unused local
 variables
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============0299807329713568557=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240609224314.GA2821752@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============0299807329713568557==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="0LPhsWsL1Ga+XLL0"
Content-Disposition: inline


--0LPhsWsL1Ga+XLL0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 08, 2024 at 08:17:54PM -0400, Leo Izen wrote:
> int idx, and int first_tcx_flag are set but not used, so this commit
> removes their declarations and assignments.
>=20
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
>  libavcodec/aac/aacdec_lpd.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c
> index 796edd2ab5..5e9909e361 100644
> --- a/libavcodec/aac/aacdec_lpd.c
> +++ b/libavcodec/aac/aacdec_lpd.c
> @@ -99,7 +99,7 @@ static void parse_qn(GetBitContext *gb, int *qn, int nk=
_mode, int no_qn)
>  static int parse_codebook_idx(GetBitContext *gb, uint32_t *kv,
>                                int nk_mode, int no_qn)
>  {
> -    int idx, n, nk;
> +    int n, nk;
> =20
>      int qn[2];
>      parse_qn(gb, qn, nk_mode, no_qn);

libavcodec/aac/aacdec_lpd.c: In function =E2=80=98parse_codebook_idx=E2=80=
=99:
libavcodec/aac/aacdec_lpd.c:117:5: error: =E2=80=98idx=E2=80=99 undeclared =
(first use in this function)
  117 |     idx =3D get_bits(gb, 4*n);
      |     ^~~

[...]
--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf

--0LPhsWsL1Ga+XLL0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZmYv/AAKCRBhHseHBAsP
q6joAJ9dNvJKonannAwvA5CcYy1P3MgKcwCfQS6hMMEs8aM+uDCZaeIkdc5U9Co=
=293o
-----END PGP SIGNATURE-----

--0LPhsWsL1Ga+XLL0--

--===============0299807329713568557==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============0299807329713568557==--