From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_lpd: remove unused local variables
Date: Mon, 10 Jun 2024 00:43:14 +0200
Message-ID: <20240609224314.GA2821752@pb2> (raw)
In-Reply-To: <20240609001754.260928-1-leo.izen@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1364 bytes --]
On Sat, Jun 08, 2024 at 08:17:54PM -0400, Leo Izen wrote:
> int idx, and int first_tcx_flag are set but not used, so this commit
> removes their declarations and assignments.
>
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
> libavcodec/aac/aacdec_lpd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c
> index 796edd2ab5..5e9909e361 100644
> --- a/libavcodec/aac/aacdec_lpd.c
> +++ b/libavcodec/aac/aacdec_lpd.c
> @@ -99,7 +99,7 @@ static void parse_qn(GetBitContext *gb, int *qn, int nk_mode, int no_qn)
> static int parse_codebook_idx(GetBitContext *gb, uint32_t *kv,
> int nk_mode, int no_qn)
> {
> - int idx, n, nk;
> + int n, nk;
>
> int qn[2];
> parse_qn(gb, qn, nk_mode, no_qn);
libavcodec/aac/aacdec_lpd.c: In function ‘parse_codebook_idx’:
libavcodec/aac/aacdec_lpd.c:117:5: error: ‘idx’ undeclared (first use in this function)
117 | idx = get_bits(gb, 4*n);
| ^~~
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-09 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 0:17 Leo Izen
2024-06-09 22:43 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240609224314.GA2821752@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git