From: "Rémi Denis-Courmont" <remi@remlab.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 2/4] lavc/mpvenc: reorder code Date: Sun, 9 Jun 2024 11:25:13 +0300 Message-ID: <20240609082515.1325134-2-remi@remlab.net> (raw) In-Reply-To: <20240609082515.1325134-1-remi@remlab.net> No functional changes. --- libavcodec/mpegvideo_enc.c | 166 ++++++++++++++++++------------------- 1 file changed, 83 insertions(+), 83 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 82bab43e14..dd92f0a3af 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -246,6 +246,89 @@ void ff_init_qscale_tab(MpegEncContext *s) } } +int ff_dct_quantize_c(MpegEncContext *s, + int16_t *block, int n, + int qscale, int *overflow) +{ + int i, j, level, last_non_zero, q, start_i; + const int *qmat; + const uint8_t *scantable; + int bias; + int max=0; + unsigned int threshold1, threshold2; + + s->fdsp.fdct(block); + + if(s->dct_error_sum) + s->denoise_dct(s, block); + + if (s->mb_intra) { + scantable= s->intra_scantable.scantable; + if (!s->h263_aic) { + if (n < 4) + q = s->y_dc_scale; + else + q = s->c_dc_scale; + q = q << 3; + } else + /* For AIC we skip quant/dequant of INTRADC */ + q = 1 << 3; + + /* note: block[0] is assumed to be positive */ + block[0] = (block[0] + (q >> 1)) / q; + start_i = 1; + last_non_zero = 0; + qmat = n < 4 ? s->q_intra_matrix[qscale] : s->q_chroma_intra_matrix[qscale]; + bias= s->intra_quant_bias*(1<<(QMAT_SHIFT - QUANT_BIAS_SHIFT)); + } else { + scantable= s->inter_scantable.scantable; + start_i = 0; + last_non_zero = -1; + qmat = s->q_inter_matrix[qscale]; + bias= s->inter_quant_bias*(1<<(QMAT_SHIFT - QUANT_BIAS_SHIFT)); + } + threshold1= (1<<QMAT_SHIFT) - bias - 1; + threshold2= (threshold1<<1); + for(i=63;i>=start_i;i--) { + j = scantable[i]; + level = block[j] * qmat[j]; + + if(((unsigned)(level+threshold1))>threshold2){ + last_non_zero = i; + break; + }else{ + block[j]=0; + } + } + for(i=start_i; i<=last_non_zero; i++) { + j = scantable[i]; + level = block[j] * qmat[j]; + +// if( bias+level >= (1<<QMAT_SHIFT) +// || bias-level >= (1<<QMAT_SHIFT)){ + if(((unsigned)(level+threshold1))>threshold2){ + if(level>0){ + level= (bias + level)>>QMAT_SHIFT; + block[j]= level; + }else{ + level= (bias - level)>>QMAT_SHIFT; + block[j]= -level; + } + max |=level; + }else{ + block[j]=0; + } + } + *overflow= s->max_qcoeff < max; //overflow might have happened + + /* we need this permutation so that we correct the IDCT, we only permute the !=0 elements */ + if (s->idsp.perm_type != FF_IDCT_PERM_NONE) + ff_block_permute(block, s->idsp.idct_permutation, + scantable, last_non_zero); + + return last_non_zero; +} + static void update_duplicate_context_after_me(MpegEncContext *dst, const MpegEncContext *src) { @@ -4565,86 +4648,3 @@ void ff_block_permute(int16_t *block, uint8_t *permutation, block[perm_j] = temp[j]; } } - -int ff_dct_quantize_c(MpegEncContext *s, - int16_t *block, int n, - int qscale, int *overflow) -{ - int i, j, level, last_non_zero, q, start_i; - const int *qmat; - const uint8_t *scantable; - int bias; - int max=0; - unsigned int threshold1, threshold2; - - s->fdsp.fdct(block); - - if(s->dct_error_sum) - s->denoise_dct(s, block); - - if (s->mb_intra) { - scantable= s->intra_scantable.scantable; - if (!s->h263_aic) { - if (n < 4) - q = s->y_dc_scale; - else - q = s->c_dc_scale; - q = q << 3; - } else - /* For AIC we skip quant/dequant of INTRADC */ - q = 1 << 3; - - /* note: block[0] is assumed to be positive */ - block[0] = (block[0] + (q >> 1)) / q; - start_i = 1; - last_non_zero = 0; - qmat = n < 4 ? s->q_intra_matrix[qscale] : s->q_chroma_intra_matrix[qscale]; - bias= s->intra_quant_bias*(1<<(QMAT_SHIFT - QUANT_BIAS_SHIFT)); - } else { - scantable= s->inter_scantable.scantable; - start_i = 0; - last_non_zero = -1; - qmat = s->q_inter_matrix[qscale]; - bias= s->inter_quant_bias*(1<<(QMAT_SHIFT - QUANT_BIAS_SHIFT)); - } - threshold1= (1<<QMAT_SHIFT) - bias - 1; - threshold2= (threshold1<<1); - for(i=63;i>=start_i;i--) { - j = scantable[i]; - level = block[j] * qmat[j]; - - if(((unsigned)(level+threshold1))>threshold2){ - last_non_zero = i; - break; - }else{ - block[j]=0; - } - } - for(i=start_i; i<=last_non_zero; i++) { - j = scantable[i]; - level = block[j] * qmat[j]; - -// if( bias+level >= (1<<QMAT_SHIFT) -// || bias-level >= (1<<QMAT_SHIFT)){ - if(((unsigned)(level+threshold1))>threshold2){ - if(level>0){ - level= (bias + level)>>QMAT_SHIFT; - block[j]= level; - }else{ - level= (bias - level)>>QMAT_SHIFT; - block[j]= -level; - } - max |=level; - }else{ - block[j]=0; - } - } - *overflow= s->max_qcoeff < max; //overflow might have happened - - /* we need this permutation so that we correct the IDCT, we only permute the !=0 elements */ - if (s->idsp.perm_type != FF_IDCT_PERM_NONE) - ff_block_permute(block, s->idsp.idct_permutation, - scantable, last_non_zero); - - return last_non_zero; -} -- 2.45.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-09 8:25 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-09 8:25 [FFmpeg-devel] [PATCH 1/4] lavc/dnxhdenc: eliminate dead code Rémi Denis-Courmont 2024-06-09 8:25 ` Rémi Denis-Courmont [this message] 2024-06-09 8:25 ` [FFmpeg-devel] [PATCH 3/4] lavc/mpv_enc: privatize ff_dct_quantize_c Rémi Denis-Courmont 2024-06-09 8:25 ` [FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init Rémi Denis-Courmont 2024-06-09 8:37 ` Andreas Rheinhardt 2024-06-09 8:39 ` Andreas Rheinhardt 2024-06-09 9:01 ` Rémi Denis-Courmont 2024-06-09 9:26 ` Andreas Rheinhardt 2024-06-09 9:31 ` Rémi Denis-Courmont 2024-06-09 9:35 ` Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240609082515.1325134-2-remi@remlab.net \ --to=remi@remlab.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git