From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CD9814B59C for ; Sat, 8 Jun 2024 23:11:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 19AEE68D725; Sun, 9 Jun 2024 02:10:58 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1346168D718 for ; Sun, 9 Jun 2024 02:10:50 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7266EC0003 for ; Sat, 8 Jun 2024 23:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1717888249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vkvTnVm2OnJ6FS00fMThIkQnzeA5KsUktMLm8B+LnFM=; b=iDjgOKyVfnenkJ2zZbta2cOFg+VGFT0cDevYf5dLPezKLl+QNtWwoKowmD7w3+d5bcMWz1 DNZHvgx/ue0Usb2Ha2JCAy4HqBYvolzPIMXE5/RXiMaqOSb8Ad8FJvCkcSeYPvNKMm7RFt nV1rr1554qRTsHxvt8OOyxbypY1HYp0f1LpbFJyLD4ikKcrPE1w9PuJkB+iVCmNWIJ+kWY gZgWo22BB1PY+n5h42Fc4+MWkLFyW+yXy+gwEsNQje/x37SvKSj6Fo1Q5xYexfxCXp6bwI UdghV3I1juZdMpg6Uwt65i9ypz/8hiJYPTtZLhHVU5J/st/wmx0Isihfe9CfxQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 9 Jun 2024 01:10:40 +0200 Message-ID: <20240608231046.3619551-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240608231046.3619551-1-michael@niedermayer.cc> References: <20240608231046.3619551-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 3/9] avformat/rtsp: initialize reply1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: It seems reply1 is initialized by ff_rtsp_send_cmd() in most cases but there are code paths like "continue" which look like they could skip it but even if not writing this so a complex loop after several layers of calls initialized a local variable through a pointer is just bad design. This patch simply initialized the variable. Fixes: CID1473532 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/rtsp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 28c858077ad..c6fca89d83f 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1462,6 +1462,8 @@ int ff_rtsp_make_setup_request(AVFormatContext *s, const char *host, int port, char cmd[MAX_URL_SIZE]; const char *trans_pref; + memset(&reply1, 0, sizeof(reply1)); + if (rt->transport == RTSP_TRANSPORT_RDT) trans_pref = "x-pn-tng"; else if (rt->transport == RTSP_TRANSPORT_RAW) -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".