From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 629084AA58 for ; Fri, 7 Jun 2024 09:54:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0E98568D781; Fri, 7 Jun 2024 12:54:00 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D4FA368D6DA for ; Fri, 7 Jun 2024 12:53:52 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0C9C21BF20C for ; Fri, 7 Jun 2024 09:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1717754032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1CDY2LVIrkHQMZ6/K0+RloZNAY+q84iFx1TIPe7tjVY=; b=f+lbW+YdNVwhjFITyqXC2un5xGRLS5h+oq+hX+m1vrPzwSP3B7uScw5znMBAZBQ9pM1l7U PTEgugNzcDWZ0mkoL1anQSFeGITTVBqJSmP/K6LMkZbRU1t7eIA1s3Q4YKoJxSyXs7S+6y G8k1YZuXGzKraNmj43JnMiAREqbY5YwmUjIL9p+yBV650WWIn3XnnlksPbl9KHHVw4Akby ZZ3peD81LYZNA+IZ58J6LvJaU8mJKpaQC8KqLI2mfUPL6zsDHG/s4w/riIvB4JUkWcbcfo 5r0uCiYf010oTLy1G1f2CbqesMV8RIB/XzQW2wV9tS7+cAhSv98VtHHF+DFWsw== Date: Fri, 7 Jun 2024 11:53:51 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240607095351.GP2821752@pb2> References: <20240606115100.44233-1-hiccupzhu@gmail.com> <2E76C656-4093-4901-B314-C61BAE6CDA15@remlab.net> MIME-Version: 1.0 In-Reply-To: <2E76C656-4093-4901-B314-C61BAE6CDA15@remlab.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2859124288544968312==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2859124288544968312== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FpiZi7hT3UZZkRL4" Content-Disposition: inline --FpiZi7hT3UZZkRL4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 07, 2024 at 09:45:09AM +0300, R=C3=A9mi Denis-Courmont wrote: > Hi, >=20 > Le 7 juin 2024 06:33:20 GMT+03:00, Shiqi Zhu a =C3= =A9crit=C2=A0: > >> Initialization and render in the same thread is one of the issues. Ano= ther > >> issue is SDL render should be run in main thread. Maybe it=E2=80=99s n= ot the > >> duty of this filter to control which thread to be called, but this wou= ldn=E2=80=99t > >> work with ffmpeg cmd. > >> > >Yes, I agree with your opinion. The control of the filter should be > >left to the application, and the ffmpeg command should only serve the > >purpose of demonstrating functionality. >=20 > You can't require running on the main thread. There are no ifs or buts he= re; libavfilter simply can't require that from the calling application or u= pper-layer framework and therefore it also can't warrant it to SDL. We can require anything from an API that we are able to change and extend Of course we can decide not to allow such requirment even if optional but we surely _could_ add such a feature if we choose to do so thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable --FpiZi7hT3UZZkRL4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZmLYrAAKCRBhHseHBAsP q2p2AJsF92P2C71rsnD6ahNEjQU7vhH5GQCfWxseOuVFtYQoliWP9z+WOa46U38= =ID8E -----END PGP SIGNATURE----- --FpiZi7hT3UZZkRL4-- --===============2859124288544968312== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2859124288544968312==--