From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 3/5] avformat/mxfdec: Check container_ul->desc before use
Date: Fri,  7 Jun 2024 02:32:13 +0200
Message-ID: <20240607003215.1723906-3-michael@niedermayer.cc> (raw)
In-Reply-To: <20240607003215.1723906-1-michael@niedermayer.cc>
Fixes: CID1592939 Dereference after null check
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/mxfdec.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index e65cec74c23..820b03940aa 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -3031,6 +3031,7 @@ static int mxf_parse_structural_metadata(MXFContext *mxf)
             if (container_ul->desc)
                 av_dict_set(&st->metadata, "data_type", container_ul->desc, 0);
             if (mxf->eia608_extract &&
+                container_ul->desc &&
                 !strcmp(container_ul->desc, "vbi_vanc_smpte_436M")) {
                 st->codecpar->codec_type = AVMEDIA_TYPE_SUBTITLE;
                 st->codecpar->codec_id = AV_CODEC_ID_EIA_608;
-- 
2.45.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply	other threads:[~2024-06-07  0:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07  0:32 [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check requested_sample before using it Michael Niedermayer
2024-06-07  0:32 ` [FFmpeg-devel] [PATCH 2/5] avformat/mpeg: Check len in mpegps_probe() Michael Niedermayer
2024-06-07  0:32 ` Michael Niedermayer [this message]
2024-06-18 14:31   ` [FFmpeg-devel] [PATCH 3/5] avformat/mxfdec: Check container_ul->desc before use Tomas Härdin
2024-06-19 11:24     ` Michael Niedermayer
2024-06-07  0:32 ` [FFmpeg-devel] [PATCH 4/5] avformat/mxfenc: Remove dead code Michael Niedermayer
2024-06-18 14:32   ` Tomas Härdin
2024-07-02 19:23     ` Michael Niedermayer
2024-06-07  0:32 ` [FFmpeg-devel] [PATCH 5/5] avformat/rdt: Check pkt_len Michael Niedermayer
2024-07-02 19:25 ` [FFmpeg-devel] [PATCH 1/5] avformat/mov: Check requested_sample before using it Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20240607003215.1723906-3-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git