From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B4B744B482 for ; Wed, 5 Jun 2024 22:44:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F1F9D68CFA2; Thu, 6 Jun 2024 01:44:05 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8A4D268D2B5 for ; Thu, 6 Jun 2024 01:43:59 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 92EC5FF803 for ; Wed, 5 Jun 2024 22:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1717627438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BTAZpHtljpdkLn0aF2KWWo8mdvjNDmQZxOgCw7lCwGU=; b=SohSiIgim2AHLsHBGaygm51Qo9PVnTkqqwyEvgsM4aWzu+S6WCAnV7F+QHu90bMAG8/DdY 3XLcdq2waolOqFDNibH4h+ZFlWZ8clB2lfowVBc9jXG6upnenn0bZ271SFP8+YSWi/TZLr NLy3lpLtxFQWmHOk+1eZOrObwan8EqPqH4NXvY+hVjMS69NZg2iM/fUhUraVXerQjGIK0E ogODFtOB0rp9+RGq6eVaeoM1TNmLvTzhI0xoNrBhdc7SVSHOpnp97D0xwprdqopdyssST5 gST9a23PrNlQ51NF8WmxBK+f6L/qtuOt2K/AVhbfvo6a6s1/VdIcJs/B7wKR2A== Date: Thu, 6 Jun 2024 00:43:57 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240605224357.GL2821752@pb2> References: <5e10ed20-f845-41a0-9a9c-91c1cb1972d8@gmail.com> MIME-Version: 1.0 In-Reply-To: <5e10ed20-f845-41a0-9a9c-91c1cb1972d8@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] Allow enabling SVC in libaomenc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6833542341814446135==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6833542341814446135== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tIeJbwHNpP5qezKJ" Content-Disposition: inline --tIeJbwHNpP5qezKJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 05, 2024 at 02:34:07PM -0700, Chun-Min Chang wrote: > This patch updates libaomenc.c to accept parameters for SVC (Scalable > Video Coding) settings via the FFmpeg API `av_opt_set`. The SVC > configuration is applied based on the provided parameters. As libaom's > SVC functionality only operates with constant bitrate encoding [1], > these parameters will only take effect when the bitrate is set to > constant. >=20 > [1] https://aomedia.googlesource.com/aom/+/a7ef80c44bfb34b08254194b1ab72d= 4e93ff4b07/av1/encoder/svc_layercontext.h#115 >=20 > Signed-off-by: Chun-Min Chang > --- > libavcodec/libaomenc.c | 75 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 75 insertions(+) Applying: Allow enabling SVC in libaomenc error: corrupt patch at line 16 error: could not build fake ancestor Patch failed at 0001 Allow enabling SVC in libaomenc thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable --tIeJbwHNpP5qezKJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZmDqKgAKCRBhHseHBAsP q7Y+AJwK0SzT4JOWn3ulII4h1hpk3n1UdACfZFYm6aB61VouiKoykTMZkRCIC3o= =8M4D -----END PGP SIGNATURE----- --tIeJbwHNpP5qezKJ-- --===============6833542341814446135== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6833542341814446135==--