From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v6 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable
Date: Wed, 5 Jun 2024 01:48:39 +0200
Message-ID: <20240604234839.GJ2821752@pb2> (raw)
In-Reply-To: <20240604053904.6382-2-connorbworley@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1060 bytes --]
On Mon, Jun 03, 2024 at 10:39:04PM -0700, Connor Worley wrote:
> Offers a modest performance gain due to the switch from naive linear
> probling to robin hood.
>
> Signed-off-by: Connor Worley <connorbworley@gmail.com>
> ---
> libavcodec/dxvenc.c | 119 ++++++++++++--------------------------------
> 1 file changed, 32 insertions(+), 87 deletions(-)
this seems to break fate
TEST dxv3enc-dxt1
--- ./tests/ref/fate/dxv3enc-dxt1 2024-06-03 22:55:42.109080592 +0200
+++ tests/data/fate/dxv3enc-dxt1 2024-06-05 01:45:58.899051887 +0200
@@ -3,4 +3,4 @@
#codec_id 0: dxv
#dimensions 0: 1920x1080
#sar 0: 1/1
-0, 0, 0, 1, 76521, 0xed387a5e
+0, 0, 0, 1, 76517, 0xd60c1020
Test dxv3enc-dxt1 failed. Look at tests/data/fate/dxv3enc-dxt1.err for details.
make: *** [tests/Makefile:311: fate-dxv3enc-dxt1] Error 1
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Never trust a computer, one day, it may think you are the virus. -- Compn
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-04 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 5:39 [FFmpeg-devel] [PATCH v6 1/2] lavu/hashtable: create generic robin hood hash table Connor Worley
2024-06-04 5:39 ` [FFmpeg-devel] [PATCH v6 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable Connor Worley
2024-06-04 23:48 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604234839.GJ2821752@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git